-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gsi_enkf.sh hash to 457510c #2514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@CatherineThomas-NOAA and @JessicaMeixner-NOAA - the GSI hash at which this PR points at resolves the correlated error problem documented in #2507. Can either of you review the changes? @WalterKolczynski-NOAA and @KateFriedman-NOAA - this PR updates the |
|
@RussTreadon-NOAA I will test to see if I get past the previous failure I had. Thank you for making these fixes! |
Thank you @JessicaMeixner-NOAA |
The CI on WCOSS had just been updated this morning midstream of this PR getting started. I am going to revert the label to Ready so it can restart with these updates. Shouldn't take too long since CI runs are quicker on WCOSS. |
|
Automated global-workflow Testing Results:
|
@RussTreadon-NOAA I can confirm that my previously failed gdasanal job succeeded when I pointed to the hash from this PR! |
Excellent! Thank you @JessicaMeixner-NOAA for running this test. |
Experiment C48_ATM_a641f7bb SUCCESS on Wcoss2 at 04/22/24 04:32:14 PM |
Experiment C96_atm3DVar_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:24:16 PM |
Experiment C96C48_hybatmDA_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:24:24 PM |
Experiment C48_S2SW_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:32:17 PM |
All CI Test Cases Passed on Wcoss2:
|
* upstream/develop: Add CCPP suite and FASTER option to UFS build (NOAA-EMC#2521) New "atmanlfv3inc" Rocoto job (NOAA-EMC#2420) Hotfix to disable STALLED in CI as an error (NOAA-EMC#2523) Add restart on failure capability for the forecast executable (NOAA-EMC#2510) Update parm/transfer list files to match vetted GFSv16 set (NOAA-EMC#2517) Update gdas_gsibec_ver to 20240416 (NOAA-EMC#2497) Adding more cycles to gempak script gfs_meta_sa2.sh (NOAA-EMC#2518) Update gsi_enkf.sh hash to 457510c (NOAA-EMC#2514) Enable using the FV3_global_nest_v1 CCPP suite (NOAA-EMC#2512) CI Refactoring and STALLED case detection (NOAA-EMC#2488) Add C768 and C1152 S2SW test cases (NOAA-EMC#2509) Fix paths for refactored prepocnobs task (NOAA-EMC#2504)
Description
The
gsi_enkf.fd
hash is updated to bring in revisions to GSI source code filesrc/gsi/correlated_obsmod.F90
. The order in which set up checks are performed have been modified to allowgsi.x
to successfully run retrospective GFS v17 cases with correlated error active.Resolves #2507
Type of change
Change characteristics
How has this been tested?
gsi.x
for failed 2021032418 case reported in issue Failures in GSI analysis due to inconsistent correlated error #2507Checklist