Add fire blending to GOCART #2883
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakernoaa
force-pushed
the
feature/fire_blending
branch
from
ee128da
to
fd0e7a5
Compare
bbakernoaa
force-pushed
the
feature/fire_blending
branch
from
fd0e7a5
to
c8e6344
Compare
aerorahul
reviewed
Sep 14, 2024
WalterKolczynski-NOAA
changed the title
aerorahul
added
CI-Gaea-Ready
As forecast ensemble jobs are added to the global workflow, this PR ensures the output is being cleaned up properly once it is no longer needed. Resolves NOAA-EMC#833
This PR updates the parm/config/gfs/config.resources and env/WCOSS2.env files for the BUFR sounding job "postsnd." It includes adjustments to resource settings such as tasks per node and memory allocations for various GFS resolutions, including C768, C1152, and others. Here are the proposed changes: C768: 7 nodes, 21 tasks per node C1152: 16 nodes, 9 tasks per node
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global-workflow Unified Post Processor (UPP) task. Refs: NOAA-EMC#2451
This PR updates the `develop` branch to use the newer operational
`obsproc/v1.2.0` and `prepobs/v1.1.0`. The obsproc/prepobs installs in
glopara space on supported platforms use tags cut from the `dev/gfsv17`
branches in the respective repos. The installation of `prepobs/v1.1.0`
on WCOSS2 is called "gfsv17_v1.1.0" to help avoid GFSv16 users using it
instead of the operational module.
Also, the `HOMEobsproc` path is updated to set an empty default for
`obsproc_run_ver`. This both removes the need to set a default (and
constantly update it, which is duplication) and avoid the unset variable
error when the fcst jobs use their own load module script that does not
know `obsproc_run_ver`:
```
export HOMEobsproc="${BASE_GIT:-}/obsproc/v${obsproc_run_ver:-}"
```
This PR also reverts the prepobs and fit2obs installs on MSU back to the
glopara space from the temporary `/work/noaa/global/kfriedma/glopara`
space installs.
Lastly, this PR also includes updates to complete issue NOAA-EMC#2844 (merge
`build.spack.ver` and `run.spack.ver`).
Resolves NOAA-EMC#2291
Resolves NOAA-EMC#2840
Resolves NOAA-EMC#2844
aerorahul
requested changes
Sep 25, 2024
There was a problem hiding this comment.
@bbakernoaa
Please let me know if any of my comments need clarifications
Comment on lines
+5
to
+30
| # TODO: this is duplicated in the config.aero file. Should use a common function | ||
| case ${machine} in | ||
| "HERA") | ||
| AERO_INPUTS_DIR="/scratch1/NCEPDEV/global/glopara/data/gocart_emissions" | ||
| ;; | ||
| "ORION" | "HERCULES") | ||
| AERO_INPUTS_DIR="/work2/noaa/global/wkolczyn/noscrub/global-workflow/gocart_emissions" | ||
| ;; | ||
| "S4") | ||
| AERO_INPUTS_DIR="/data/prod/glopara/gocart_emissions" | ||
| ;; | ||
| "WCOSS2") | ||
| AERO_INPUTS_DIR="/lfs/h2/emc/global/noscrub/emc.global/data/gocart_emissions" | ||
| ;; | ||
| "GAEA") | ||
| AERO_INPUTS_DIR="/gpfs/f5/epic/proj-shared/global/glopara/data/gocart_emissions" | ||
| ;; | ||
| "JET") | ||
| AERO_INPUTS_DIR="/lfs4/HFIP/hfv3gfs/glopara/data/gocart_emissions" | ||
| ;; | ||
| *) | ||
| echo "FATAL ERROR: Machine ${machine} unsupported for aerosols" | ||
| exit 2 | ||
| ;; | ||
| esac | ||
| export AERO_INPUTS_DIR |
There was a problem hiding this comment.
I think we can/shouldplace AERO_INPUTS_DIR in workflow/hosts/<machine>.yaml and then here, replace this section with:
export AERO_INPUTS_DIR="@AERO_INPUTS_DIR@"Repeat the same in config.aero.
What do you think @WalterKolczynski-NOAA ?
ps. this can be done in a follow-up PR.
Comment on lines
+301
to
+310
| if len(obsfile) > 1: | ||
| if "QFED".lower() in obsfile[0].lower(): | ||
| g = AerosolEmissions.open_qfed(obsfile) | ||
| else: | ||
| g = xr.open_mfdataset(obsfile, decode_cf=False) | ||
| else: | ||
| if "QFED".lower() in obsfile.lower(): | ||
| g = AerosolEmissions.open_qfed(obsfile) | ||
| else: | ||
| g = xr.open_mfdataset(obsfile, decode_cf=False) |
There was a problem hiding this comment.
Why not make obsfile a list, and avoid this duplication.
Suggested change
| if len(obsfile) > 1: | |
| if "QFED".lower() in obsfile[0].lower(): | |
| g = AerosolEmissions.open_qfed(obsfile) | |
| else: | |
| g = xr.open_mfdataset(obsfile, decode_cf=False) | |
| else: | |
| if "QFED".lower() in obsfile.lower(): | |
| g = AerosolEmissions.open_qfed(obsfile) | |
| else: | |
| g = xr.open_mfdataset(obsfile, decode_cf=False) | |
| if isinstance(obsfile, (str, bytes)): | |
| obsfile = [obsfile] | |
| if "QFED".lower() in obsfile[0].lower(): | |
| g = AerosolEmissions.open_qfed(obsfile) | |
| else: | |
| g = xr.open_mfdataset(obsfile, decode_cf=False) |
| climo = climo.sel(lat=g["lat"], lon=g["lon"], method="nearest") | ||
|
|
||
| # make weighted climo | ||
| gc = g.coarsen(lat=150, lon=150, boundary="trim").sum() |
There was a problem hiding this comment.
Should these coarse grid values be configurable in the yaml?
| dsets = [] | ||
| climo_scaled = {} | ||
| for tslice in np.arange(len(climos)): | ||
| print(tslice) |
| """Perform closing actions of the task. | ||
| Copy data back from the DATA/ directory to COM/ | ||
| """ | ||
| print(Config_dict.data_out) |
| """ | ||
| Generate fire emissions data for a given date and forecast period. | ||
|
|
||
| Parameters: |
There was a problem hiding this comment.
Please use numpy documentation formatting.
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Change characteristics
How has this been tested?
Checklist