Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UPP links to .gitignore #2904

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

DavidHuber-NOAA
Copy link
Contributor

Description

This adds 3 missing links from the UPP into parm/ufs to .gitignore.

Resolves #2901

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

git status after running link_workflow.sh on Hera.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Sep 11, 2024

I think this is a deeper issue than Russ's issue suggests. There are no GEFS flat files here. The forecast is (correctly) staging the files from parm/post. I think these files can just be removed.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @WalterKolczynski-NOAA for your comment. The issue could indeed be deeper than my bug report. I didn't dig into what's going on. Would the UPP team know or provide guidance on developing the correct changes to make in this PR?

@WalterKolczynski-NOAA
Copy link
Contributor

Thank you @WalterKolczynski-NOAA for your comment. The issue could indeed be deeper than my bug report. I didn't dig into what's going on. Would the UPP team know or provide guidance on developing the correct changes to make in this PR?

Pretty sure this is purely a workflow issue. We know which ones to use, we just need to make sure we are using them.

@DavidHuber-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA As is, there is not an itag file for GEFS, so the workflow is copying in parm/ufs/post_itag_gfs for both GFS and GEFS forecasts:

${NCP} "${PARMgfs}/ufs/post_itag_gfs" "${DATA}/itag" # TODO: Need a GEFS version when available in the UFS-weather-model

That said, I will remove the postxconfig files from parm/ufs and .gitignore.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Sep 11, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Sep 11, 2024
@emcbot
Copy link

emcbot commented Sep 12, 2024

CI Passed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/2904


Experiment C48mx500_3DVarAOWCDA_4f150020 Completed 2 Cycles: *SUCCESS* at Thu Sep 12 01:38:23 UTC 2024
Experiment C48_ATM_4f150020 Completed 1 Cycles: *SUCCESS* at Thu Sep 12 01:38:23 UTC 2024
Experiment C96C48_hybatmDA_4f150020 Completed 3 Cycles: *SUCCESS* at Thu Sep 12 02:51:59 UTC 2024
Experiment C96_atm3DVar_4f150020 Completed 3 Cycles: *SUCCESS* at Thu Sep 12 02:58:07 UTC 2024
Experiment C48_S2SWA_gefs_4f150020 Completed 1 Cycles: *SUCCESS* at Thu Sep 12 03:10:39 UTC 2024
Experiment C48_S2SW_4f150020 Completed 1 Cycles: *SUCCESS* at Thu Sep 12 03:22:34 UTC 2024
Experiment C96C48_ufs_hybatmDA_4f150020 Completed 2 Cycles: *SUCCESS* at Thu Sep 12 03:22:34 UTC 2024
Experiment C96C48_hybatmaerosnowDA_4f150020 Completed 3 Cycles: *SUCCESS* at Thu Sep 12 03:53:25 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 108db4d into develop Sep 12, 2024
13 of 14 checks passed
DavidNew-NOAA pushed a commit to DavidNew-NOAA/global-workflow that referenced this pull request Sep 13, 2024
This adds 3 missing links from the UPP into parm/ufs to .gitignore.

Resolves NOAA-EMC#2901
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 16, 2024
* emc/develop:
  Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917)
  Cleanup job for GEFS (NOAA-EMC#2919)
  Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912)
  add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922)
  Support gefs C48 on Azure (NOAA-EMC#2881)
  Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
  Add new UPP links to .gitignore (NOAA-EMC#2904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files missed in .gitingore
5 participants