Update snow obs preprocessing job #2946
Conversation
Replace it with a direct read from BUFR at runtime.
workflow/rocoto/gfs_cycled_xml.py
Outdated
| if self._app_config.do_jedisnowda: | ||
| sdate_snocvr = self._base['SDATE'] | ||
| edate_snocvr = self._base['EDATE'] | ||
| interval_snocvr = to_timedelta(f"24:00:00H") |
There was a problem hiding this comment.
| interval_snocvr = to_timedelta(f"24:00:00H") | |
| interval_snocvr = to_timedelta('24H') |
There was a problem hiding this comment.
Made changes. Thanks.
workflow/rocoto/gfs_tasks.py
Outdated
| task_dict = {'task_name': task_name, | ||
| 'resources': resources, | ||
| 'dependency': dependencies, | ||
| 'envars': self.envars, | ||
| 'cycledef': self.run.replace('enkf', ''), | ||
| 'command': f'{self.HOMEgfs}/jobs/rocoto/prepsnowobs.sh', | ||
| 'cycledef': cycledef, |
There was a problem hiding this comment.
| 'cycledef': cycledef, | |
| 'cycledef': 'gdas_prep_snocvr', |
There was a problem hiding this comment.
Made changes as suggested. Thanks.
workflow/rocoto/gfs_tasks.py
Outdated
|
|
||
| deps = [] | ||
| dep_dict = {'type': 'task', 'name': f'{self.run}prep'} | ||
| deps.append(rocoto.add_dependency(dep_dict)) | ||
| dependencies = rocoto.create_dependency(dep=deps) | ||
|
|
||
| resources = self.get_resource('prepsnowobs') | ||
| task_name = f'{self.run}prepsnowobs' | ||
| cycledef = 'gdas_prep_snocvr' |
There was a problem hiding this comment.
| cycledef = 'gdas_prep_snocvr' |
workflow/rocoto/gfs_tasks.py
Outdated
| @@ -591,7 +592,10 @@ def prepsnowobs(self): | |||
| def snowanl(self): | |||
|
|
|||
| deps = [] | |||
| dep_dict = {'type': 'task', 'name': f'{self.run}prepsnowobs'} | |||
| if f'@H' == '00': | |||
There was a problem hiding this comment.
@H is a rocoto thing, so this doesn't have any meaning to python when this function is run and this won't work as-is. #2928 is adding support for the undocumented rocoto dependency <taskvalid>. Once that is in, we can use it to make a dependency that works here:
<or>
<and>
<not><taskvalid task="{self.run}prepsnowcover"/></not>
<taskdep task="{self.run}prep"/>
</and>
<taskdep task="{self.run}prepsnowcover"/>
</or>
There was a problem hiding this comment.
Thanks @WalterKolczynski-NOAA for the information. Your introduced <taskvalid> above is exactly what we want here. For now, I made some changes here for a place holder.
<or>
<taskdep task="gdasprep"/>
<taskdep task="gdasprepsnowcover"/>
</or>
WalterKolczynski-NOAA
added
the
blocked
Description
This PR modifies the workflow XML configuration so that the prep snow obs job only runs on the 00z cycle.
This PR also renames the
snow_obsandsnowobsto thesnowcoverfor highlighting the input IMS data source as snow cover.Resolves (#2902)
Type of change
Change characteristics
How has this been tested?
Checklist