Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ocean variables for post-processing in GEFS #2995

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

EricSinsky-NOAA
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA commented Oct 9, 2024

Description

This PR adds an ocean variable tob (Sea Water Potential Temperature at Sea Floor) for post-processing in GEFS, which is a variable that has been requested for GEFSv13 and the reforecast.

Also, this PR moves the atmos variable PEVPR from the "b" group to the "a" group of pgrb products in GEFS. This was requested by a reforecast stakeholder.

Resolves #2993

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

These changes have been tested on WCOSS2. This PR will be left as a draft until the necessary gfs-utils PR is merged.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@EricSinsky-NOAA
Copy link
Contributor Author

After testing this branch with the latest gfs_utils hash, the new ocean variable tob is successfully being post-processed in the ocean_prod task. Also, PEVPR is being successfully written to the "a" atmos pgrb file group. Marking this PR as ready for review.

@EricSinsky-NOAA EricSinsky-NOAA marked this pull request as ready for review October 10, 2024 19:46
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Oct 10, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Oct 10, 2024
@emcbot
Copy link

emcbot commented Oct 10, 2024

Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 1 in
/work2/noaa/stmp/CI/HERCULES/2995/RUNTESTS/EXPDIR/C96_S2SWA_gefs_replay_ics_172223cd

@EricSinsky-NOAA
Copy link
Contributor Author

A change needed to be made to the name of one of the extractvars dependencies due to the changes made in PR #2981. This change has been committed in d7a10a9.

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Oct 11, 2024
@emcbot
Copy link

emcbot commented Oct 11, 2024

CI Failed on Hercules in Build# 1
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2995


Experiment C48_ATM_172223cd Completed 1 Cycles: *SUCCESS* at Thu Oct 10 17:10:58 CDT 2024
Experiment C96_S2SWA_gefs_replay_ics_172223cd Terminated with 0 tasks failed and 0 dead at Thu Oct 10 17:17:06 CDT 2024
Experiment C96_S2SWA_gefs_replay_ics_172223cd Terminated: *STALLED*
Experiment C96_atm3DVar_172223cd Completed 3 Cycles: *SUCCESS* at Thu Oct 10 18:11:56 CDT 2024
Experiment C96C48_hybatmDA_172223cd Completed 3 Cycles: *SUCCESS* at Thu Oct 10 18:30:24 CDT 2024
Experiment C48_S2SW_172223cd Completed 1 Cycles: *SUCCESS* at Thu Oct 10 19:24:18 CDT 2024
Experiment C48_S2SWA_gefs_172223cd Completed 1 Cycles: *SUCCESS* at Thu Oct 10 19:31:16 CDT 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more ocean variables for ocean post-processing in GEFS
3 participants