Update to tiled fix files, UGWD v1, NOAH-MP #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates model to use tiled fix files. Fix directory is updated to the fix_NEW location. Adds the ability to use UGWD v1. Since this capability is tied to the CCPP suite used, the sutie definition file is grepped to determine whether UGWD is active. Otherwise, gwd_opt 1 is used. Either way, the appropriate namelist settings are added to input.nml. For v1, the necessary fix files are also linked to the run directory. If additional options are supported in the future, there will need to be more sophisicated parsing. Adds the ability to use Noah-MP. Like UGWD, this is dictated by the CCPP suite used, so the suite definition file is grepped to determine whether to use Noah (lsm=1) or Noah-MP (lsm=2). Additional CCPP suites are added to allow for the new options. The two non-fractional coupled cases are updated to use a CCPP suite using both UGWD v1 and Noah-MP. The two aerosol cases are updated to a suite using UGWD v1 (there does not appear to be an atm-only suite that has both). There is also a minor change to the UFS build script to remove any existing UFS build directory. This prevents problems when attempting to build a different app after one has already been built. Closes: NOAA-EMC#331, NOAA-EMC#346
WalterKolczynski-NOAA
requested review from
rmontuoro,
JessicaMeixner-NOAA and
yangfanglin
|
Confirmed to work for coupled_wave, coupled, and firex. Also tested firex with the old CCPP suite to confirm the old settings still work. |
This was
linked to
issues
Jul 24, 2021
rmontuoro
approved these changes
Jul 26, 2021
JessicaMeixner-NOAA
approved these changes
Jul 26, 2021
Previously there was no guarantee that CCPP_SUITE was set before it was used in forecast_postdet.sh. The suite how has a default value if it is not set. A default later in the execution chain is removed, as CCPP_SUITE is now guaranteed to be set beforehand. The default is also updated to FV3_GFS_v16. There is also now a check to ensure the suite file is present inside the UFS directory before trying to determine settings from it. Refs: NOAA-EMC#346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates model to use tiled fix files. Fix directory is updated to the
fix_NEW location.
Adds the ability to use UGWD v1. Since this capability is tied to the
CCPP suite used, the sutie definition file is grepped to determine whether
UGWD is active. Otherwise, gwd_opt 1 is used. Either way, the appropriate
namelist settings are added to input.nml. For v1, the necessary fix files
are also linked to the run directory. If additional options are supported
in the future, there will need to be more sophisicated parsing.
Adds the ability to use Noah-MP. Like UGWD, this is dictated by the CCPP
suite used, so the suite definition file is grepped to determine whether
to use Noah (lsm=1) or Noah-MP (lsm=2).
Additional CCPP suites are added to the build to allow for the new options.
The two non-fractional coupled cases are updated to use a CCPP suite using
both UGWD v1 and Noah-MP. The two aerosol cases are updated to a suite using
UGWD v1 (there does not appear to be an atm-only suite that has both).
There is also a minor change to the UFS build script to remove any existing
UFS build directory. This prevents problems when attempting to build a
different app after one has already been built.
Closes: #331, #346