Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series of small WCOSS2 updates - round 10 #620

Conversation

KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA commented Jan 31, 2022

Description

This PR includes some updates for the WCOSS2 port:

  1. bug fix in scripts/exgfs_atmos_gempak_meta.sh which was found and fixed by @WeiWei-NCO
  2. resource updates for several GSI/EnKF jobs based on feedback from @RussTreadon-NOAA and @MichaelLueken-NOAA
  3. cleans up nco.static resource configs to support only operations on WCOSS2; the emc.dyn resource configs support other tier 1 platforms
  4. updates the EMC tag name in the release notes to the new tag that will be cut after this PR goes in (EMC-v16.2.0.3)

Refs: #398, #399

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Regular port updates - resources

How Has This Been Tested?

Both @WeiWei-NCO and myself tested the included updates on Dogwood. We confirmed good timings on adjusted jobs.

- NCO/Wei found an infinite loop in the exgfs_atmos_gempak_meta.sh
script during para testing
- Provided and tested a fix, confirmed fix with Boi

Refs: NOAA-EMC#399
- Russ Treadon provided resource adjustments to several GSI/EnKF jobs to
get them closer to their WCOSS1 ops timings and use fewer cores
- The enkfgdas_select_obs (gdaseobs), enkfgdas_update (gdaseupd),
gdas_atmos_analysis_diag (gdasanaldiag), and gdas_atmos_analysis
(gdasanal) jobs have been updated
- The updated resources have been incorporated into the relevant ecf
script PBS directives and resource configs

Refs: NOAA-EMC#399
@KateFriedman-NOAA KateFriedman-NOAA added the port Porting the system to a new platform label Jan 31, 2022
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Jan 31, 2022
- not needed since setup script math results in 9ppn for eupd when using
14 threads

Refs: NOAA-EMC#399
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about uneven node counts for @RussTreadon-NOAA

parm/config/config.resources.emc.dyn Show resolved Hide resolved
parm/config/config.resources.nco.static Outdated Show resolved Hide resolved
@KateFriedman-NOAA KateFriedman-NOAA marked this pull request as ready for review January 31, 2022 20:56
- the new EMC hand-off tag is EMC-v16.2.0.3

Refs: NOAA-EMC#399
- clean up config.resources.nco.static and config.fv3.nco.static to
remove non-WCOSS2 and non-ops refererences
- both nco.static resource configs now only support operations on WCOSS2
and preserve the operational resource settings
- the emc.dyn resource configs will be modified further to support other
tier 1 platforms

Refs: NOAA-EMC#399
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could theoretically replace all of the math with constants, but that might be too much work for now.

parm/config/config.fv3.nco.static Show resolved Hide resolved
@KateFriedman-NOAA KateFriedman-NOAA merged commit 5a080b4 into NOAA-EMC:feature/ops-wcoss2 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port Porting the system to a new platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants