Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUOPC cap to the model to support external land component under UFS #1

Merged
merged 94 commits into from
Oct 28, 2022

Conversation

uturuncoglu
Copy link
Collaborator

This PR aims to add ESMF/NUOPC cap to the Noah MP model. The cap basically uses noahmpdrv.F90 which is provided by CCPP to drive the model. The current version of the model is tested with data model configurations and also side-by-side configuration with active atmosphere under UFS Weather model and new RTs are defined. This version of code also includes files for component testing through the GitHub action. In this case, the datm+lnd configuration (very similar to the RT test that is defined under UFS Weather Model) with is compiled outside of the UFS Weather Model and runs for one day.

cenlinhe and others added 30 commits November 30, 2021 15:39
Merge develop branch to master branch
re-structure NoahMP repo by moving other noahmp files from HRLDAS repo
Sync with updated develop branch
Sync with updated develop branch
Sync with updated develop branch
@BrianCurtis-NOAA
Copy link

This is ready for merge at the UFSWM level. Please review as needed and merge.

@BrianCurtis-NOAA
Copy link

@barlage Can you review please?

Copy link
Collaborator

@barlage barlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR supports the implementation of noahmp component model based on a snapshot of ccpp-physics version of the code. Eventually, when ccpp-physics submodules the NOAA-EMC fork of NCAR, this will need to be updated. I have some minor concerns about the storage of netcdf tiles that are not relevant for non-UFS applications of noahmp, but that hopefully can be dealt with later.

@uturuncoglu
Copy link
Collaborator Author

@barlage Could you also give me admin access to this repository once you merge the PR. So, I could make some minor modifications to activate testing with GitHub action. Once, we have working action, you could change the access privileges to the original version.

@barlage
Copy link
Collaborator

barlage commented Oct 28, 2022

@uturuncoglu do you have a minute to talk about this? I'm having trouble merging to develop.

@uturuncoglu
Copy link
Collaborator Author

sure.

@uturuncoglu uturuncoglu merged commit 34a52cc into NOAA-EMC:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants