Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM changes for GFSv17 COM reorganization #17

Closed
KateFriedman-NOAA opened this issue Mar 15, 2023 · 4 comments
Closed

COM changes for GFSv17 COM reorganization #17

KateFriedman-NOAA opened this issue Mar 15, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@KateFriedman-NOAA
Copy link
Member

As part of the GFSv17 upgrade the structure of COM is changing. Companion changes are needed in prepobs. See more in the global-workflow issue: NOAA-EMC/global-workflow#761

@ilianagenkova When a prepobs release branch is created for the GFSv17 implementation these changes should be included. Will hold in a feature branch (feature/GFSv17_com_reorg) until that point for use by GFS developers running cycled experiments. Will keep the feature branch synced with operational updates as needed until release branch for v17 is created.

Changes provided by @WalterKolczynski-NOAA from his COM reorg testing.

@KateFriedman-NOAA KateFriedman-NOAA added the enhancement New feature or request label Mar 15, 2023
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Mar 15, 2023
@ilianagenkova ilianagenkova self-assigned this Mar 15, 2023
@ilianagenkova
Copy link
Collaborator

All bufr dumps (*.bufr_d) and various flavors of prepbufr files are written in the same directory, so this should be a coordinated GFSv17 - obsproc/prepobs/bufr-dump update.

@WalterKolczynski-NOAA, when you say COM do you mean $COMROOT/gfs/{gfs_ver}/... ? Just to be clear.
Operationally, observations can't go there, but in $COMROOT/obsproc.

We can change the path from:
$COMROOT/obsproc/{obsproc_ver}/gdas[gfs].{pdy}/{cc}/atmos/*bufr.d[*prepbufr]
to
$COMROOT/obsproc/{obsproc_ver}/gdas[gfs].{pdy}/{cc}/*bufr.d[*prepbufr]
Is this the ask?

@WalterKolczynski-NOAA
Copy link

WalterKolczynski-NOAA commented Mar 15, 2023

@ilianagenkova This is more about the location of the GFS files moving than anything about the location of obs. For development purposes, we also link in obs from the dump archive and that is also changing, but that shouldn't matter for prepobs/obsproc. I believe the only change will be to ush/getges_driver.sh. We'll be making the changes, so I don't think we need anything from you right now.

@ilianagenkova
Copy link
Collaborator

@WalterKolczynski-NOAA, I got it...it's you impacting us, thanks! Not long ago there was a separate convo about merging /atmos and /wave observations to just /obs , so I jumped to conclusions.

Yes, let us know where the guess fields end up so we update getges. Thank you!

WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/prepobs that referenced this issue Apr 10, 2023
The upcoming update to GFS v17 will substantially change the COM paths
for the GFS package. This requires updates to the lookback capability of
getges_driver where it checks previous cycles. Rather than add additional
logical branches to handle new COM patterns, the process is generalized by
instead doing a string substitution to replace the current day and cycle
with those for the prior cycle. This method is backwards compatible and
should work for any path as long as it contains `${PDY}/${cyc}`.

Additional changes will likely be needed for GFSv17 to run prepobs stand-
alone (as in ops) to match the new `$COMINgdas` and `$COMINgfs`, but
these changes work when running prepobs as part of global workflow in
development.

Also, I have not otherwise modified the existing style of the scripts,
redefining `$COMINgdas` and `$COMINgfs`. However, this will need to be
changed before GFSv17 to stop overwriting these variables to meet NCO
requirements (see NOAA-EMC/global-workflow#293).

Refs: NOAA-EMC#17
Refs: NOAA-EMC/global-workflow#761
@KateFriedman-NOAA
Copy link
Member Author

Completed via PR #19. Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants