Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update files to build and run prepobs on Gaea C5 #35

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

DavidBurrows-NCO
Copy link

Added modulefiles/prepobs_gaea.lua to build prepobs on Gaea-C5. Spack-stack gsi-addon-dev environment used for bufr/11.7.0.
Tested with C96_atm3DVar.yaml experiment from the global-workflow CI tests.

Refs #32
Refs NOAA-EMC/global-workflow #2766

I'm starting this PR in draft mode. Gaea-C5 will only be supporting a legacy ksh version, which does not support regex expressions (extended globbing is supported instead.) For this reason, prepobs/v1.0.2/install/ush/prepobs_makeprepbufr.sh silently fails with [1620]: syntax error: unexpected operator/operand '=~' on this line: if [[ "$COMSP" =~ (^/com/|^/com2/|^/gpfs/.../nco/ops/com/). The C96_atm3DVar workflow still completes successfully. I'm tracking a ticket with Gaea SA, and hopefully will resolve this set back soon.

Copy link
Collaborator

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks!

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good, thanks @DavidBurrows-NCO !

I will recut the prepobs.v1.1.0-rd-gfsv17 tag after this goes in so you can install that tag as v1.1.0 on Gaea for users.

@KateFriedman-NOAA
Copy link
Member

@DavidBurrows-NCO did you want me to wait to merge this because of the ksh issue? I am opening issues in obsproc/prepobs to request that they convert to bash.

@DavidBurrows-NCO
Copy link
Author

@KateFriedman-NOAA Since it's not causing failures in the workflow, I think it's okay to go ahead and merge. If you see any issues with that, please let me know. Thanks.

@KateFriedman-NOAA
Copy link
Member

Okie dokie, I'll proceed with merging and recutting the tag. Thanks @DavidBurrows-NCO !

@KateFriedman-NOAA KateFriedman-NOAA merged commit f88b853 into NOAA-EMC:dev/gfsv17 Sep 3, 2024
@DavidBurrows-NCO DavidBurrows-NCO deleted the cycled branch September 4, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup prepobs dev/gfsv17 to compile and run C96_atm3DVar CI test on Gaea-C5
3 participants