Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back RRFS ecflow workflow into the package #429

Merged

Conversation

lgannoaa
Copy link
Contributor

@lgannoaa lgannoaa commented Aug 9, 2024

$HOMErrfs/parm/config - It is a new directory used by ecflow for production.
An approved solution for workflow configuration in prior implementation.
This directory has no impact to rocoto workflow.
$HOMErrfs/ecf - This is the ecflow workflow directory.
This directory has no impact to rocoto workflow.
$HOMErrfs/jobs/JRRFS_FSM - This is the J-Job used by ecflow File manager job.
$HOMErrfs/scripts/exrrfs_fsm.sh - This is the ex-ecript used by ecflow File manager job.
$HOMErrfs/versions/run.ver - A fix was put in place for obsproc_ver.
(GitHub Issue - 428)

TESTS CONDUCTED:

Running retro and realtime on wcoss.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

$HOMErrfs/parm/config - It is a new directory used by ecflow for production.
                        An approved solution for workflow configuration in prior implementation.
                        This directory has no impact to rocoto workflow.
$HOMErrfs/ecf         - This is the ecflow workflow directory.
                        This directory has no impact to rocoto workflow.
$HOMErrfs/jobs/JRRFS_FSM - This is the J-Job used by ecflow File manager job.
$HOMErrfs/scripts/exrrfs_fsm.sh - This is the ex-ecript used by ecflow File manager job.
$HOMErrfs/versions/run.ver - A fix was put in place for obsproc_ver.
(GitHub Issue - 428)
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one overwhelms github with the number of new files, but will take it on faith.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 516c03b into NOAA-EMC:production/RRFS.v1 Aug 9, 2024
@BenjaminBlake-NOAA
Copy link
Contributor

Thanks @lgannoaa for merging your changes! Did you test them with the dev-sci branch or the production/RRFS.v1 branch? I see some variables in exrrfs_fsm.sh which have been renamed in the production/RRFS.v1 branch, such as NWGES_BASEDIR (NWGES) and fcst_fv3lam (forecast). So I think those variable names will have to be updated to be able to run in the production/RRFS.v1 branch. I took a half day on Friday so didn't get a chance to comment on this PR before it was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants