Updates from RRFS_A v0.7.3 retro tests #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set tg3_from_soil=True for make_ics.
hu5970
requested review from
MatthewPyle-NOAA and
JacobCarley-NOAA
as code owners
|
@chan-hoo @MatthewPyle-NOAA Please review this PR. Hopefully, we can build v0.7.3 based on this PR. |
chan-hoo
reviewed
Nov 7, 2023
| @@ -2,14 +2,6 @@ | |||
| #### NEMS Run-time Configuration File ##### | |||
| ############################################# | |||
|
|
|||
| # ESMF # | |||
There was a problem hiding this comment.
@hu5970, do you have any reason for removing this part? This if-statement can keep the ufs-weather-model printing out a large number of PET* log files.
There was a problem hiding this comment.
Yes, this part somehow blocked OMP to use multiple threads. I do not know why but we have to live with a large number of PET* log files for now.
There was a problem hiding this comment.
@chan-hoo Are you okay with it despite this little annoyance?
MatthewPyle-NOAA
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workflow is tested on Dogwood with retrospective experiments and compared with the GSL RRFS_dev1 tag 0.7.1.
Several small updates needed to match the current RRFS_A v0.7.1:
This PR addresses issue #92
The retro experiments are conducted on Dogwood and got identical results between v0.7.1 and v0.7.3 for control cycle and ensemble DA cycle in initial/boundary, GSI/EnKF analysis, nonvar cloud analysis, data process, and model forecast restart files.
Also, the wall time for each components are similar to the v0.7.1.