add components for surface snow data #14
Conversation
emilyhcliu
requested review from
rmclaren,
xincjin-NOAA,
nicholasesposito and
PraveenKumar-NOAA
| coordinates: "longitude latitude" | ||
| source: variables/stationIdentification | ||
| longName: "Identification of Observing Location" | ||
| units: "index" |
There was a problem hiding this comment.
What is "index" ? Should this always be used for stationIdentification?
| @@ -0,0 +1,22 @@ | |||
| time window: | |||
| begin: "2018-04-14T21:00:00Z" | |||
| end: "2023-12-15T03:00:00Z" | |||
| @@ -0,0 +1,20 @@ | |||
| time window: | |||
| begin: "2018-04-14T21:00:00Z" | |||
| end: "2023-12-15T03:00:00Z" | |||
| container.replace('variables/totalSnowDepth', snod) | ||
| snod_upd = container.get('variables/totalSnowDepth') | ||
|
|
||
| masked_container = _mask_container(container, (~snod.mask)) |
There was a problem hiding this comment.
Instead of making those snod values equal 0, did you mean to mask them out instead? In this case you can modify the snod.mask directly (the True value means to mask out for numpy masked arrays).
There was a problem hiding this comment.
@rmclaren I took the sfcsno Python code from GDASApp PR #1368 and modified it to following our Python code template. I did not change how the derived variable was done. For sfcsno converter, the data is read out from BUFR (10K+ data) and then applies data filtering to remove missing data. The output file ends up with much less data (~3K).
| logger = Logger('BUFR2IODA_sfcsno.py', level=log_level, colored_log=False) | ||
|
|
||
|
|
||
| def logging(comm, level, message): |
There was a problem hiding this comment.
We might want to make a logging module that we can import, so that we do not need to redefine this function in every py mapping file.
We don't have to do this now.
There was a problem hiding this comment.
I will do this in my next PR.
| @@ -1,5 +1,5 @@ | |||
| ## Test bufr_query mapping, Python converter script, and ioda configuration YAML in obsForge | |||
| This is a prototype for testing BUFR to IODA conversion and is still evolving. | |||
| This is a prototype for testing BUFR to NETCDF/IODA conversion and is still evolving. | |||
There was a problem hiding this comment.
We will use this for ZARR as well... These could also be used in IODA backends too.
|
|
||
| - bufr_satwnd_amv_goes.py | ||
| - bufr_satwnd_amv_goes.py (copied /spoc/dump/mapping) |
There was a problem hiding this comment.
This is a stand-alone test. So, the uses need to gather (copy) the required input files (bufr, mapping, python script, configuration files) in their working directory along with the test script (encodeBufr.sh) to run the test.
There was a problem hiding this comment.
bufr_bufr_backend ? maybe rename
There was a problem hiding this comment.
We have four tests:
bufr2netcdf
script2netcdf
bufr_backend
script_backend
How about we change the two backend tests to the following:
bufr_backend ---> bufr4backend
script_backend ---> script4backend
This PR includes the following changes:
bufr2iodatobufr(more general)