Skip to content

Commit

Permalink
fix(plot.FIMSFrame): Adds y and ...
Browse files Browse the repository at this point in the history
For plot to be properly documented and rendered all arguments must be
present in the methods, previously we only had x, which led to scales
not being seen as a package that was needed. Now that y and ... have
been added the package is compiling without the error noted by

Part of #671
Close the PR #672, which is no longer needed with this commit. The
methods proposed in #672 was a work around where this commit fixes the
problem.
  • Loading branch information
kellijohnson-NOAA committed Dec 5, 2024
1 parent 10ba7ed commit f7ddef6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/fimsframe.R
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ setMethod(
setMethod(
f = "plot",
signature = "FIMSFrame",
definition = function(x) {
definition = function(x, y, ...) {
ggplot2::ggplot(
data = x@data,
mapping = ggplot2::aes(
Expand Down

0 comments on commit f7ddef6

Please sign in to comment.