Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#242 fix codecov calc and upload #436

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

k-doering-NOAA
Copy link
Member

What is the feature?

Fix calculating and pushing code coverage reports to codecov.io. Addresses #242

How have you implemented the solution?

  • Turns on the call-calc-coverage.yml workflow that uses covr::codecov()
  • This calculates the coverage for both R and C++ code
  • Remove the code coverage step from run-googletest.yml, since it was not doing what it was supposed to.
  • Note I'm not sure if the build triggers are what we want or not - right now, it runs on every push and manually, but maybe only running to every push on main and on pull requests to main (and manually) are necessary?

Does the PR impact any other area of the project?

Not directly

How to test this change

Developer pre-PR checklist

  • I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

delete codecov step from run gtest
Copy link
Contributor

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree with your suggestions. I think only running to every push on main and on pull requests to main (and manually) are necessary.

@k-doering-NOAA
Copy link
Member Author

Thanks @Bai-Li-NOAA ! I added the build triggers, and also excluded some paths when coverage should not be expected to change (e.g.,changes only to the README).

I also realized it might be helpful to have codecov add a comment to our pull requests with information about coverage, so I turned on the option.

@ChristineStawitz-NOAA ChristineStawitz-NOAA merged commit d877064 into main Aug 15, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA deleted the 242-fix-codecov-rebased branch August 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants