-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: modularize R tests with helper functions and fixtures #651
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 78.88% 78.78% -0.11%
==========================================
Files 36 36
Lines 1975 1975
Branches 141 141
==========================================
- Hits 1558 1556 -2
- Misses 374 376 +2
Partials 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Bai-Li-NOAA.
Nice to see so much redundant code getting reduced and documentation improved.
4b38fdd
to
fbcd878
Compare
What is the feature?
How have you implemented the solution?
tests/testthat/fixtures
folder and used this test data across multiple tests (e.g.,tests/testthat/test-integration-fims-estimation.R
andtests/testthat/test-parallel-with-snowfall.R
)tests/testthat/helper-integration-tests-setup.R
to set up the FIMS model and validate FIMS results using simulated test dataDoes the PR impact any other area of the project, maybe another repo?
tests/testthat/helper-integration-tests-setup.R
and the examples intests/testthat/test-integration-fims-estimation.R
to set up additional integration tests.