Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops printing pointer addresses to the screen #694

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

kellijohnson-NOAA
Copy link
Contributor

What is the feature?

  • stops printing pointer addresses to the screen

How have you implemented the solution?

Does the PR impact any other area of the project, maybe another repo?

  • Makes everyone's day better 😉

to stop the address of the pointer from being printed to the screen when
creating a model. This was apparent in the vignette when the addresses
showed up in the rendered output. You could also see it in the console.
Thanks to @rklasky for finding the fix.
@kellijohnson-NOAA kellijohnson-NOAA added kind: refactor Restructure code to improve the implementation of FIMS P3 low priority task theme: code cleanup labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete!
  • For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
  • Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
  • Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
  • PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
  • Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

  • The PR is requested to be merged into the appropriate branch (typically main)
  • The code is well-designed.
  • The functionality is good for the users of the code.
  • Any User Interface changes are sensible and look good.
  • The code isn’t more complex than it needs to be.
  • Code coverage remains high, indicating the new code is tested.
  • The developer used clear names for everything.
  • Comments are clear and useful, and mostly explain why instead of what.
  • Code is appropriately documented (doxygen and roxygen).

@kellijohnson-NOAA
Copy link
Contributor Author

@Bai-Li-NOAA can you merge this in once you think it is good because I will be away from my computer for a while this morning. Also, it is not a big deal if this does not get merged in today because I can easily deal with merge conflicts later.

Copy link
Contributor

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, and everything looks great!

@Bai-Li-NOAA Bai-Li-NOAA merged commit 6bf52e8 into dev Dec 6, 2024
11 checks passed
@Bai-Li-NOAA Bai-Li-NOAA deleted the dev-stop-printing branch December 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: refactor Restructure code to improve the implementation of FIMS P3 low priority task theme: code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants