#4 - subroutines coupler_full_chksum and coupler_stocks #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full/full_coupler_mod.F90
Outdated
| logical, optional, intent(in) :: init_stocks, finish_stocks !< control flags to either call flux_init_stocks or | ||
| !! the final flux_check_stocks | ||
|
|
||
| logical :: init, finish |
There was a problem hiding this comment.
Add documentation for these variables
thomas-robinson
previously approved these changes
May 30, 2024
rem1776
reviewed
May 31, 2024
rem1776
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
The back-to-back calls to
atmos_ice_land_chksumandocean_chksumare combined and replaced with a new subroutine called coupler_atmos_ice_land_ocean_chksum. This conservative PR did not attempt to incorporate subroutinescoupler_chksumto coupler_atmos_ice_land_ocean_chksum. Doing so would have led to CHECKSUM-related changes in stdout.In addition, the subroutines coupler_flux_init_finish_stocks and coupler_flux_check_stocks have been created and are used to replace stock-related sections of coupler_main. In coupler_flux_init_finish_stocks, either
flux_init_stocksor thefinal _flux_check_stockswill be called depending on the valuesinit_stocksandfinish_stocksoptional arguments.AM4, AM5, SPEAR, OM4_extra, and OMIP4_CORE2 regression tests pass. The CHECKSUMS in stdout were not checked for ensemble regression tests.