11 - update_land_model_fast to update_atmos_model_state #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coupler_update_atmos_model_radiation coupler_update_atmos_model_down coupler_flux_down_from_atmos
update_ice_model_fast coupler_flux_up_to_atmos coupler_update_atmos_model_up coupler_flux_atmos_to_ocean
… atmos_model-flux_down
…_fast-atmos_ocean
… tracer_driver_sfc_boundary_test
… atmos_model-flux_down
… land_fast-atmos_ocean
uramirez8707
approved these changes
Jun 20, 2024
full/coupler_main.F90
Outdated
|
|
||
| call flux_ex_arrays_dealloc | ||
| !> atmosphere dynamics | ||
| if (do_atmos) call coupler_update_atmos_model_dynamics(Atm, current_timestep, & |
There was a problem hiding this comment.
I think this changes the behavior from before. Before, the checksums were always printed as long as do_chksum was true. In this code, the checksums will be printed if do_atmos is .True. and do_chksum is .True.. This is more efficient. Similar comment applies below too.
There was a problem hiding this comment.
You're right, we've warned the scientists the chksums will not be computed if do_atmos = .False. which makes sense since they won't change from the previous chksum computation
thomas-robinson
requested changes
Jun 20, 2024
rem1776
reviewed
Jun 20, 2024
rem1776
approved these changes
Jun 20, 2024
thomas-robinson
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the following coupler subroutines have been defined:
Currently tests are running
The fast coupler loop has been labeled