Fixes to run the null model #75
Conversation
simple/ice_model.F90
Outdated
| @@ -524,8 +526,12 @@ subroutine ice_model_init ( Ice, Time_Init, Time, & | |||
| !enddo | |||
| !enddo | |||
|
|
|||
| ! check if io domain set up, if so check if file can be opened | |||
| do_io = associated( mpp_get_io_domain(Ice%domain) ) | |||
There was a problem hiding this comment.
Wouldn't it be simpler to set the io_domain to (1,1) here and at L1175 when it's undefined? There are still tests to ensure the file exists.
There was a problem hiding this comment.
I had figured if it wasn't using the io domain it would be better not to set it, but probably doesn't make much of a difference. I'll change it to that instead.
simple/ice_model.F90
Outdated
| @@ -524,8 +526,12 @@ subroutine ice_model_init ( Ice, Time_Init, Time, & | |||
| !enddo | |||
| !enddo | |||
|
|
|||
| ! check if io domain set up, if so check if file can be opened | |||
| do_io = associated( mpp_get_io_domain(Ice%domain) ) | |||
| if( do_io ) do_io = open_file(land_mask_fileobj, 'INPUT/land_mask.nc', 'read', Ice%domain) | |||
There was a problem hiding this comment.
Since you are resetting the variable used within the if-test, have you checked to make sure there isn't an error when do_io=.T. and the return from open_file sets do_io to .F.? I definitely wouldn't rely in Intel unless we have strict language compliance enabled.
simple/ice_model.F90
Outdated
| @@ -524,8 +526,12 @@ subroutine ice_model_init ( Ice, Time_Init, Time, & | |||
| !enddo | |||
| !enddo | |||
|
|
|||
| ! check if io domain set up, if so check if file can be opened | |||
| do_io = associated( mpp_get_io_domain(Ice%domain) ) | |||
There was a problem hiding this comment.
@rem1776 have you tested this with the aquaplanet and doubly periodic?
There was a problem hiding this comment.
I did but I'll double check with the current FMS before I merge this in
Changes the script to add an option to copy FMS instead of cloning in order to run in the CI for NOAA-GFDL/FMS#975 , and changes the output so it'll be displayed on github.
Also makes a few code changes to allow the null model tests to run.
The ice model would fail from attempting to read without an io domain, so the added code just checks for an associated io domain before it tries to open the ice files.