Modify the halo extents of u and vt in the regional_boundary_update call #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all that caused a reproducibility issue.
|
I support this change - did a great deal of debugging trying to find out why the results change when the layout is changed, and this change fixes the problem. According to Ratko, this also solves the b4b issues in the regional runs when different numbers of threads are used. Update 2020/09/24: note that this PR is for branch ufs-release/public-v2. I added this PR to my PRs for ufs-weather-model and other submodules, see ufs-community/ufs-weather-model#205. |
|
@chan-hoo - has this already been included in NOAA-EMC repo? |
Not yet. We need this in NOAA-GFDL:ufs-release/public-v2 rather sooner than later to prepare for the SRW App release. But we will need to bring it back to dev/emc in one or the other way, of course. |
|
Dusan submitted a PR to merge GFDL dev/emc fork to EMC fork, we can make
another merge when Chan-hoo's change is committed to GFDL dycore.
…On Thu, Sep 24, 2020 at 3:33 PM Dom Heinzeller ***@***.***> wrote:
@chan-hoo <https://github.com/chan-hoo> - has this already been included
in NOAA-EMC repo?
Not yet. We need this in NOAA-GFDL:ufs-release/public-v2 rather sooner
than later to prepare for the SRW App release. But we will need to bring it
back to dev/emc in one or the other way, of course.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLTT2BFS3SL5EWCP7LSHONJHANCNFSM4RW7ZIXQ>
.
|
|
Thanks, Rusty @bensonr! |
|
@chan-hoo@climbfuji <https://github.com/climbfuji> will the corresponding
PR be made to GFDL repo or the emc fork?
…On Thu, Sep 24, 2020 at 5:39 PM Dom Heinzeller ***@***.***> wrote:
Thanks, Rusty @bensonr <https://github.com/bensonr>!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNGUDWLS2IDK2D33ODSHO4BRANCNFSM4RW7ZIXQ>
.
|
|
@junwang-noaa I can merge this over to the NOAA-GFDL:dev/emc branch for you to pull into the EMC fork. Let me know if this is acceptable. |
|
That will be good,thanks.
…On Fri, Sep 25, 2020 at 8:59 AM bensonr ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> I can merge this over to
the NOAA-GFDL:dev/emc branch for you to pull into the EMC fork. Let me know
if this is acceptable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLUNDGUFKG6522EFADSHSH4JANCNFSM4RW7ZIXQ>
.
|
MicroTed
pushed a commit
to MicroTed/GFDL_atmos_cubed_sphere
that referenced
this pull request
Sep 22, 2021
…erturbations (NOAA-GFDL#239) * Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch * RUC ice for gsl/develop (replaces NOAA-GFDL#54 and NOAA-GFDL#56) (NOAA-GFDL#60) Implementation of RUC LSM ice model in CCPP * Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge * Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics * Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml * Update gsl/develop from develop 2020/12/08 (NOAA-GFDL#61) * Fix for updating stochastic physics on separate time-step. (NOAA-GFDL#199) This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns. The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section. * Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (NOAA-GFDL#204) * -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T; -- Not setting fice to zero in order to leave lake ice untouched; -- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time; Co-authored-with: Shrinivas Moorthi <shrinivas.moorthi@noaa.gov> Co-authored-with: Denise Worthen <Denise.Worthen@noaa.gov> * Revert change to .gitmodules and update submodule pointer for ccpp-physics * Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (NOAA-GFDL#63) * Land stochastic perturbations (wrapper PR for NOAA-GFDL#65) (NOAA-GFDL#68) * Move initialization of stochastic physics after the physics initialization in CCPP. * Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM. * Max/min soil moisture variables are introduced via GFS_Control_type variables instead of through the use of namelist_soilveg*. This is a more flexible way for different LSMs. * Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90. * Remove tracer_sanitizer from all suites and from CCPP prebuild config * Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90 * Stochastic land perturbations: add roughness length over land to the perturbed variables (NOAA-GFDL#70) * Added roughness length over land to the perturbed variables. * Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated * Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing * Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics * Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com> Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: shansun6 <48043606+shansun6@users.noreply.github.com> Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov>
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
…stack Updates for Spack Stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the halo extents of 'u' and 'vt' fields in the 'regional_boundary_update' call that caused a reproducibility issue on FV3-LAM (Limited Area Model).
Tested with two different MPI layouts (4x6) and (6x4) on Hera. In testing, the 'FV3_GFS_2017_gfdlmp_regional' CCPP suite was applied.
The modified version has resolved the bit-difference reproducibility issue.