Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregistered diagnostic warnings in CMIP6 test run #168

Open
jkrasting opened this issue Sep 21, 2017 · 8 comments
Open

Unregistered diagnostic warnings in CMIP6 test run #168

jkrasting opened this issue Sep 21, 2017 · 8 comments

Comments

@jkrasting
Copy link
Contributor

In the CMIP6 test run, fms.out reports the following diagnostics as unregistered. i.e. they are requested by the diag_table but not output by the model. Several of these may just be diag requests related to parameterizations that are in the OM4_05 configuration but not in the OM4_025 configuration.

  1. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_x_2d_T) NOT registered
  2. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_y_2d_T) NOT registered
  3. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_x_2d_S) NOT registered
  4. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_y_2d_S) NOT registered
  5. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/fsitherm) NOT registered
  6. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_x_2d_T) NOT registered
  7. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_y_2d_T) NOT registered
  8. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_x_2d_S) NOT registered
  9. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_trans_y_2d_S) NOT registered
  10. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/fsitherm) NOT registered
  11. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/hfsolidrunoffds) NOT registered
  12. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/hfsolidrunoffds) NOT registered
  13. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/opottemppmdiff) NOT registered
  14. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/opottemppmdiff) NOT registered
  15. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_conc_tendency_T) NOT registered
  16. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_conc_tendency_T) NOT registered
  17. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_conc_tendency_S) NOT registered
  18. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/ndiff_tracer_conc_tendency_S) NOT registered
  19. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/opottemppmdiff_2d) NOT registered
  20. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/osaltpmdiff_2d) NOT registered
  21. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/opottemppmdiff_2d) NOT registered
  22. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model/osaltpmdiff_2d) NOT registered
  23. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model_z/osaltpmdiff) NOT registered
  24. WARNING from PE 576: diag_util_mod::opening_file: module/field_name (ocean_model_z/osaltpmdiff) NOT registered
@StephenGriffies
Copy link
Contributor

hfsolidrunoffds
heat content of solid runoff relative to 0C. So if the solid runoff has temperature 0C, then we do not need to have a term here. I thought we received the heat content of solid and liquid runoff from the land model. If so, then hfsolidrunoffds should be filled. .

neutral diffusion terms not used in OM4_p25
osaltpmdiff
osaltpmdiff_2d
opottemppmdiff_2d
ndiff_tracer_conc_tendency_S
ndiff_tracer_conc_tendency_T
ndiff_tracer_trans_y_2d_S
ndiff_tracer_trans_y_2d_T

fsitherm this term is the sea ice melt mass flux going into the ocean. Do we have this information passed to MOM6 from SIS2? It would be nice to have this field available from MOM6. But perhaps it is saved from SIS2?

@adcroft
Copy link
Member

adcroft commented Sep 21, 2017

They are just warnings - because the 05 and 025 models are currently using the same daig_table I have to leave them in.

@adcroft
Copy link
Member

adcroft commented Sep 21, 2017

...or we could have a delta for the 05 diag_table that the xml joins on ...

@StephenGriffies
Copy link
Contributor

Only the ndiff diagnostics are the 05 versus 025 warnings. The other two, fsitherm and hfsolidrunoffds, require action.

@ashao
Copy link
Collaborator

ashao commented Sep 21, 2017

RE: fsitherm

@StephenGriffies: fsitherm seems to be included as part of the liquid precipation varible in the forcing type. You had left a comment about separating it out, but I don't think that got changed. I'll check the coupler
https://github.com/NOAA-GFDL/MOM6/blob/950718fb7854895760417841c407ddc35fa192a4/src/core/MOM_forcing_type.F90#L671-L684

@ashao
Copy link
Collaborator

ashao commented Sep 21, 2017

Note, those lines apply for the heat flux calculation involving lprec.

@ashao
Copy link
Collaborator

ashao commented Sep 21, 2017

RE: fsitherm
These lines in SIS2 (https://github.com/NOAA-GFDL/SIS2/blob/17245e81b26c95eff4cc4d26ec6347f9cea3e96d/src/SIS_slow_thermo.F90#L1305-L1309) and other commented out code in the forcing type suggests that as of now we don't have an 'fsitherm' diagnostic

@StephenGriffies
Copy link
Contributor

Yes, I recall now. Thanks @ashao for checking.

adcroft added a commit that referenced this issue Dec 19, 2020
@adcroft
MOM6: Merge main-candidate-ncar-2020-12-15 to main
bad2d00 
- PR to main from NCAR
- Adds diagnostics

- NOAA-GFDL/MOM6@0f664aa82 Merge pull request #1275 from gustavo-marques/main-candidate-ncar-2020-12-15
- NOAA-GFDL/MOM6@9d04f3849 Sets CS%limiter_remap=.false. in near_boundary_unit_tests
- NOAA-GFDL/MOM6@5739a3413 Merge branch 'delete_fotgotten_code_LBD' into main-candidate-ncar-2020-12-15
- NOAA-GFDL/MOM6@51ed387ae Delete forgotten code
- NOAA-GFDL/MOM6@42d79c204 Merge branch 'main' into main-candidate-ncar-2020-12-15
- NOAA-GFDL/MOM6@eddbd6c09 Merge pull request #164 from gustavo-marques/LBD_regrid_merged_10nov2020
- NOAA-GFDL/MOM6@cf97095bd Fix bug in linear decay and set F_layer = 0 below htot_max
- NOAA-GFDL/MOM6@8215b70d0 Merge pull request #163 from NCAR/stdout
- NOAA-GFDL/MOM6@0c1680555 Merge pull request #168 from kshedstrom/gnu_fix
- NOAA-GFDL/MOM6@37cea3690 A few fixes to get it to compile with gfortran.
- NOAA-GFDL/MOM6@acdfdda71 Fix unit tests and declare max_depth
- NOAA-GFDL/MOM6@ad9862b40 Set maximum depth of the LBD grid
- NOAA-GFDL/MOM6@5ac184667 Merge pull request #165 from NCAR/deferred_char_len
- NOAA-GFDL/MOM6@7a5a0f768 real_array_string to deferred length
- NOAA-GFDL/MOM6@95271cdfb change mesg character var to be deferred length to prevent record overflow
- NOAA-GFDL/MOM6@d5c87fc5a change left_reals character var to be deferred length to prevent record overflow
- NOAA-GFDL/MOM6@fa2b4249b Undo chages in tracer_example and MOM_tracer_flow_control
- NOAA-GFDL/MOM6@aa27f1c8e Add LBD clock, clean up, and document module
- NOAA-GFDL/MOM6@48616d86a Delete uncessary comments
- NOAA-GFDL/MOM6@11cc3dc5c Undo changes related to check_grid_def
- NOAA-GFDL/MOM6@f5abc66b7 Fix bug in linear decay
- NOAA-GFDL/MOM6@f0d8a4ae1 Merge branch 'dev/ncar' into HEAD
- NOAA-GFDL/MOM6@3f092914e replace iso_fortran_env::stdout with MOM_io::stdout
- NOAA-GFDL/MOM6@1269874f2 change all 'write(*,..' to 'write(stdout,...'
- NOAA-GFDL/MOM6@cc82d1154 use MOM_io::stdout in MCT cap instead of glb%stdout or FMS stdout
- NOAA-GFDL/MOM6@30fac75c0 introduce public module ints stdout and stderr for standard output
- NOAA-GFDL/MOM6@165b1b27a Merge pull request #160 from gustavo-marques/merge-main-candidate-2020-09-18
- NOAA-GFDL/MOM6@9fbc3e663 Merge pull request #6 from NOAA-GFDL/main-candidate-2020-09-18
- NOAA-GFDL/MOM6@300b6e9cf Option to apply limiter in native and LBD grids
- NOAA-GFDL/MOM6@60559ecc1 Code cleaning
- NOAA-GFDL/MOM6@9fb6f7527 Fix unit tests
- NOAA-GFDL/MOM6@e484bc87a Add option to set maximum value in subrotine unique
- NOAA-GFDL/MOM6@3df9dbcc7 Merge branch 'dev/ncar' into merge-regrid_LBD
- NOAA-GFDL/MOM6@9e7b08973 Improve flux limiter
- NOAA-GFDL/MOM6@a962325d8 Add option to apply flux limiter
- NOAA-GFDL/MOM6@4235bb2fc Merge pull request #159 from gustavo-marques/add_u_v_squared_diags
- NOAA-GFDL/MOM6@ddbd9c7ae Merge pull request #158 from gustavo-marques/dev-master-candidate-ncar-2020-08-11
- NOAA-GFDL/MOM6@f0face43f Adds missing args for KPP_get_BLD and energetic_PBL_get_MLD
- NOAA-GFDL/MOM6@87ba533e4 Adds missing args for KPP_get_BLD and energetic_PBL_get_MLD
- NOAA-GFDL/MOM6@2538c4d2a Improve the merging of interfaces
- NOAA-GFDL/MOM6@f444affd3 Comment out write statements
- NOAA-GFDL/MOM6@4ab4a7af7 Remove hard-coded BLD and uncomment code for adv and PGF
- NOAA-GFDL/MOM6@365b298be Cleanup + add unit tests
- NOAA-GFDL/MOM6@e537ef233 Add option to initialize passive tracer from z file
- NOAA-GFDL/MOM6@40136b6d2 Passes GV to lateral_boundary_diffusion_init
- NOAA-GFDL/MOM6@441c34ef4 Define vertical grid on-the-fly using h's and BLDs
- NOAA-GFDL/MOM6@75c587e5f Major re-arragement to remap u- and v-fluxes
- NOAA-GFDL/MOM6@593ebfc1d Delete fluxes_bulk_method
- NOAA-GFDL/MOM6@e0db9abcb Fix typo when posting vsq
- NOAA-GFDL/MOM6@1849bccd4 Adding option to output u^2, v^2 and u*v
- NOAA-GFDL/MOM6@5c56268ea Adding options to specify dz to apply LBD @ top
- NOAA-GFDL/MOM6@fa376e4da Merge branch 'LBD_idealized_experiments2' into regrid_LBD
- NOAA-GFDL/MOM6@2a8096497 First attempt to use remapping in LBD
- NOAA-GFDL/MOM6@d8ae09f80 Rename lateral_boundary_diffusion_CS to lbd_CS
- NOAA-GFDL/MOM6@9957e55c6 Fix bug in loop-indices when using discontinuous ND and interior_only
- NOAA-GFDL/MOM6@1fd53935d Fix bug in loop-indices when applying linear decay
- NOAA-GFDL/MOM6@a49954a73 comment calls to BLD schemes
- NOAA-GFDL/MOM6@7e390593c Merge branch 'dev/ncar' into LBD_idealized_experiments
- NOAA-GFDL/MOM6@09ad69505 Add option to apply linear decay at the base of hbl
- NOAA-GFDL/MOM6@7299d8653 Fix bug when applying ND only in the interior
- NOAA-GFDL/MOM6@92581e2be Minor improvements in the bulk method
- NOAA-GFDL/MOM6@9dc47208a Add option to apply linear decay at the base of hbl
- NOAA-GFDL/MOM6@3b121cbcd Merge branch 'fix_LBD_tests' into LBD_idealized_experiments
- NOAA-GFDL/MOM6@51a4d2e11 Apply a linear transition in LBD methods 1, 2
- NOAA-GFDL/MOM6@b5132d99d Modifications to run idealized two-column LBD
- NOAA-GFDL/MOM6@a446d0fb2 Remove dependence on the boundary layer scheme
OlgaSergienko pushed a commit to OlgaSergienko/MOM6-examples that referenced this issue Dec 29, 2020
@alperaltuntas
Merge pull request NOAA-GFDL#168 from kshedstrom/gnu_fix
0c16805 
A few fixes to get it to compile with gfortran.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StephenGriffies @ashao @adcroft @jkrasting