Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated diag table for transport diags #179

Closed
wants to merge 2 commits into from
Closed

Updated diag table for transport diags #179

wants to merge 2 commits into from

Conversation

jkrasting
Copy link
Contributor

  • T_ady_2d and T_adx_2d now in ocean_month
    output stream (needed for CMIP6)
  • Added umo to ocean_month output stream

  - T_ady_2d and T_adx_2d now in ocean_month
    output stream (needed for CMIP6)
  - Added umo to ocean_month output stream
@@ -162,7 +166,7 @@
"ocean_model_z","vo", "vo", "ocean_month_z", "all", "mean", "none",2
#"ocean_model", "vo", "vo", "ocean_month", "all", "mean", "none",2
#"ocean_model", "umo", "umo", "ocean_annual", "all", "mean", "none",2
"ocean_model_z","umo", "umo", "ocean_annual_z", "all", "mean", "none",2
"ocean_model_z","umo", "umo", "ocean_month_z", "all", "mean", "none",2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I added vmo to ocean_month_z I deliberately did not add umo because @StephenGriffies agreed it would never be used. Has that conclusion changed?

@jkrasting
Copy link
Contributor Author

jkrasting commented Oct 5, 2017 via email

@adcroft adcroft mentioned this pull request Oct 5, 2017
@adcroft
Copy link
Member

adcroft commented Oct 5, 2017

Of course - then we still need a mod on this PR because ocean_annual_z was changed to ocean_month_z but vmo is in both, so umo should be too.

Leave L165 unchanged and uncomment L166.

@jkrasting
Copy link
Contributor Author

jkrasting commented Oct 5, 2017 via email

@adcroft
Copy link
Member

adcroft commented Oct 5, 2017

It didn't show up in this PR?

@jkrasting
Copy link
Contributor Author

jkrasting commented Oct 5, 2017 via email

@adcroft
Copy link
Member

adcroft commented Oct 5, 2017

Changes in this PR are already in #178 so we are closing this one (#179).

@adcroft adcroft closed this Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants