Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kd_interface diagnostic incomplete in newer diabatic_ALE #398

Closed
kshedstrom opened this issue Jul 10, 2023 · 1 comment
Closed

Kd_interface diagnostic incomplete in newer diabatic_ALE #398

kshedstrom opened this issue Jul 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kshedstrom
Copy link

The Kd_interface diagnostic in diabatic_ALE is a copy of Kd_heat before the double diffusion contribution, but also before the ePBL contribution. One could instead have it be Kd_heat minus KT_extra at the end, or just note that Kd_interface isn't what one should be asking for.
@Hallberg-NOAA Hallberg-NOAA added the bug Something isn't working label Dec 18, 2023
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue May 16, 2024
@Hallberg-NOAA
(*)Fix Kd_interface diag in newer diabatic_ALE
ed6d7eb 
  Corrected the field being posted for the Kd_interface diagnostic inside of
diabatic_ALE() to be the minimum of Kd_heat and Kd_salt, which includes the
contributions from ePBL, but excluding any extra double-diffusive mixing, making
it analogous to the diagnostic that is currently being posted from
layered_diabatic() or diabatic_ALE_legacy().  Diabatic_ALE() is used when
USE_REGRIDDING=True and USE_LEGACY_DIABATIC_DRIVER=False, in which case a
diagnostic will change, correcting the issue noted at
NOAA-GFDL/issues/398.  All solutions are bitwise identical.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue May 16, 2024
Merged
marshallward pushed a commit that referenced this issue Jun 5, 2024
@Hallberg-NOAA @marshallward
(*)Fix Kd_interface diag in newer diabatic_ALE
9ab5f34 
  Corrected the field being posted for the Kd_interface diagnostic inside of
diabatic_ALE() to be the minimum of Kd_heat and Kd_salt, which includes the
contributions from ePBL, but excluding any extra double-diffusive mixing, making
it analogous to the diagnostic that is currently being posted from
layered_diabatic() or diabatic_ALE_legacy().  Diabatic_ALE() is used when
USE_REGRIDDING=True and USE_LEGACY_DIABATIC_DRIVER=False, in which case a
diagnostic will change, correcting the issue noted at
/issues/398.  All solutions are bitwise identical.
@Hallberg-NOAA
Copy link
Member

This issue was corrected by PR #635.

c2xu pushed a commit to c2xu/MOM6 that referenced this issue Jun 11, 2024
@Hallberg-NOAA @c2xu
(*)Fix Kd_interface diag in newer diabatic_ALE
cfb9dba 
  Corrected the field being posted for the Kd_interface diagnostic inside of
diabatic_ALE() to be the minimum of Kd_heat and Kd_salt, which includes the
contributions from ePBL, but excluding any extra double-diffusive mixing, making
it analogous to the diagnostic that is currently being posted from
layered_diabatic() or diabatic_ALE_legacy().  Diabatic_ALE() is used when
USE_REGRIDDING=True and USE_LEGACY_DIABATIC_DRIVER=False, in which case a
diagnostic will change, correcting the issue noted at
NOAA-GFDL/issues/398.  All solutions are bitwise identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kshedstrom @Hallberg-NOAA