+Add user-controlled underflow of tracers #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #131 +/- ##
============================================
- Coverage 33.45% 33.45% -0.01%
============================================
Files 262 262
Lines 71388 71413 +25
Branches 13323 13336 +13
============================================
+ Hits 23884 23891 +7
- Misses 43032 43048 +16
- Partials 4472 4474 +2
Continue to review full report at Codecov.
|
|
This could have computational performance implications that should be investigated before merging. If the underflows can be applied in a separate loop, with the underflow criterion outside of the loop, then that would be a much safer option. |
Hallberg-NOAA
force-pushed
the
full_tracer_underflow
branch
from
79a0fda to
1dde1c1
Compare
Added the ability to do software-controlled underflow of user-specified tiny tracer values to 0. This includes the addition of two new runtime parameters, SALINITY_UNDERFLOW and TEMPERATURE_UNDERFLOW, and the addition of the new optional argument underflow_conc to register_tracer. There is new code that optionally underflows tiny values after tracer advection, all three flavors of tracer diffusion, and after tracer remapping via ALE. By default, underflow is handled via the machine as before, but with appropriately set tiny values of SALINITY_UNDERFLOW and TEMPERATURE_UNDERFLOW, of 1e-30 ppt and 1e-30 degC, all existing test cases pass the dimensional consistency rescaling tests for temperature and salinity, but doing so does change answers slightly for some test cases (detectible in the restart files, but not in the ocean.stats files). By default all answers are bitwise identical, but there are two new runtime parameters.
Moved the new user-controlled tracer underflow code into separate loops, in response to the reviews of this initial commit, in the hopes that this will provide better computational performance. All answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
full_tracer_underflow
branch
from
1dde1c1 to
601036c
Compare
marshallward
approved these changes
Jun 6, 2022
marshallward
added
the
Parameter change
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15715 ✔️ 🟡 New parameters:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to do software-controlled underflow of user-specified tiny
tracer values to 0. This includes the addition of two new runtime parameters,
SALINITY_UNDERFLOW and TEMPERATURE_UNDERFLOW, and the addition of the new
optional argument underflow_conc to register_tracer. There is new code that
optionally underflows tiny values after tracer advection, all three flavors of
tracer diffusion, and after tracer remapping via ALE. By default, underflow is
handled via the machine as before, but with appropriately set tiny values of
SALINITY_UNDERFLOW and TEMPERATURE_UNDERFLOW, of 1e-30 ppt and 1e-30 degC, all
existing test cases pass the dimensional consistency rescaling tests for
temperature and salinity, but doing so does change answers slightly for some
test cases (detectible in the restart files, but not in the ocean.stats files).
By default all answers are bitwise identical, but there are two new runtime
parameters.