(*)Use visc%Kv_shear in calculate_CVMix_conv call #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use visc%Kv_shear in the calculate_CVMix_conv call in layered_diabatic, to avoid segmentation faults when USE_REGRIDDING=True and USE_CVMix_CONVECTION=True but USE_KPP=False. This bug was identified when evaluating the changes in NOAA-GFDL#129, and a correction was requested, but the correction was omitted from that PR. Answers could change, but it is likely that any cases that would change would previously have encountered a segmentation fault, so I suspect that no such cases exist.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #146 +/- ##
=========================================
Coverage 34.25% 34.25%
=========================================
Files 257 257
Lines 69721 69721
Branches 12909 12909
=========================================
Hits 23885 23885
Misses 41365 41365
Partials 4471 4471
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15940 ✔️ |
marshallward
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use visc%Kv_shear in the calculate_CVMix_conv call in layered_diabatic, to
avoid segmentation faults when USE_REGRIDDING=True and USE_CVMix_CONVECTION=True
but USE_KPP=False. This bug was identified when evaluating the changes in
#129, and a correction was requested, but
the correction was omitted from that PR. Answers could change, but it is likely
that any cases that would change would previously have encountered a
segmentation fault, so I suspect that no such cases exist.