+Add an interface filtering capability #195
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #195 +/- ##
============================================
- Coverage 37.22% 37.17% -0.05%
============================================
Files 261 262 +1
Lines 72499 72595 +96
Branches 13554 13578 +24
============================================
+ Hits 26985 26986 +1
- Misses 40514 40604 +90
- Partials 5000 5005 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Anecdotal confirmation FWIW, I also started getting bus errors only on C3 and immediately after the update to C3, with a much older version of MOM6. I have a help desk ticket in. |
Added the new module MOM_interface_filter to allow for a biharmonic or other order of filtering of the interface heights. This new capability is enabled with the new runtime parameter APPLY_INTERFACE_FILTER, and with rates of filtering determined by the new runtime parameters INTERFACE_FILTER_TIME, INTERFACE_FILTER_MAX_CFL, INTERFACE_FILTER_ORDER and INTERFACE_FILTER_ISOTROPIC. Set APPLY_INTERFACE_FILTER to True and provide a positive timescale in INTERFACE_FILTER_TIME to enable the filtering. The comments describing THICKNESSDIFFUSE and THICKNESSDIFFUSE_FIRST were also updated to clarify the distinctions with the new capabilities or to clearly identify which parameters work together. By default, all answers are bitwise identical, but there are new entries or modified comments in the MOM_parameter_doc files.
Corrected the doxygen comments for the interface filtering module, to avoid a section-name conflict with the GM module, and renamed some internal variables for greater clarity when reading the code. All answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
filter_interface
branch
from
18db92d to
7017f1a
Compare
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16697 ✔️ 🟡 |
Added the new module MOM_interface_filter to allow for a biharmonic or
other order of filtering of the interface heights. This new capability
is enabled with the new runtime parameter APPLY_INTERFACE_FILTER, and with
rates of filtering determined by the new runtime parameters
INTERFACE_FILTER_TIME, INTERFACE_FILTER_MAX_CFL, INTERFACE_FILTER_ORDER and
INTERFACE_FILTER_ISOTROPIC. Set APPLY_INTERFACE_FILTER to True and provide a
positive timescale in INTERFACE_FILTER_TIME to enable the filtering.
The comments describing THICKNESSDIFFUSE and THICKNESSDIFFUSE_FIRST were
also updated to clarify the distinctions with the new capabilities or to
clearly identify which parameters work together.
By default, all answers are bitwise identical, but there are new entries or
modified comments in the MOM_parameter_doc files.
(Note: In some recent runs, I have been getting bus errors with some runs on Gaea, but I am also
getting this with the most recent version of dev/gfdl, so I suspect that this is a problem with a recent
update to Gaea, which occurred shortly before these errors started occurring, so I strongly suspect
that this is a problem with Gaea, and not a problem with this PR.)