POSIX: generic wrappers for all setjmp.h symbols #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #355 +/- ##
============================================
- Coverage 38.13% 38.13% -0.01%
============================================
Files 269 269
Lines 75731 75743 +12
Branches 13926 13926
============================================
Hits 28882 28882
- Misses 41650 41662 +12
Partials 5199 5199
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This patch extends the generic wrappers of sigsetjmp to all of the *jmp wrapper functions in <setjmp.h> The C standard allows these to be defined as macros, rather than explicit functions, which cannot be referenced by Fortran C bindings, so we cannot assume that these functions exist, even when using a compliant libc. As with sigsetjmp, these functions are now disabled on default, and raise a runtime error if called by the program. Realistically, they will only be defined by an autoconf-configured build. This is required for older Linux distributions where libc does not define longjmp.
Hallberg-NOAA
force-pushed
the
posix_jmp_fixes
branch
from
347a3fc to
8ed7eb0
Compare
Hallberg-NOAA
approved these changes
May 27, 2023
There was a problem hiding this comment.
These changes look reasonable to me, and they have passed the pipeline testing at
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19305 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the generic wrappers of sigsetjmp to all of the *jmp wrapper functions in <setjmp.h>
The C standard allows these to be defined as macros, rather than explicit functions, which cannot be referenced by Fortran C bindings, so we cannot assume that these functions exist, even when using a compliant libc.
As with sigsetjmp, these functions are now disabled on default, and raise a runtime error if called by the program. Realistically, they will only be defined by an autoconf-configured build.
This is required for older Linux distributions where libc does not define longjmp.