Autoconf: External FMS build configuration #362
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #362 +/- ##
============================================
- Coverage 38.13% 38.13% -0.01%
============================================
Files 269 269
Lines 75743 75743
Branches 13926 13926
============================================
- Hits 28883 28882 -1
- Misses 41660 41662 +2
+ Partials 5200 5199 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
force-pushed
the
deps_no_fms_diffs
branch
from
2ead450 to
0a8d45c
Compare
marshallward
changed the title
|
My simple edit of the commit's subject may have exposed some race conditions in the Makefiles (they are popping up in my personal repo, not on this PR). Looking into it... |
marshallward
force-pushed
the
deps_no_fms_diffs
branch
from
0a8d45c to
b5f2ee9
Compare
|
A more explicit specification of the It was known to be an unhandled dependency, but I had thought other dependencies took care of it. Shifting work over to the copy of |
This patch modifies the `ac/deps` Makefile used to build the FMS depedency. The autoconf compilation is now done entirely outside of the `ac/deps/fms/src` directory. This keeps the FMS checkout unchanged and allows us to better track any development changes in that library during development. The .testing/Makefile was also modified to use existing rules in deps/Makefile rather than duplicating them. Dependency of the m4 directory is also now more explicit (albeit still somewhat incomplete).
Hallberg-NOAA
force-pushed
the
deps_no_fms_diffs
branch
from
b5f2ee9 to
3a16927
Compare
There was a problem hiding this comment.
These changes look sensible to me, and they have passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19308.
This patch modifies the
ac/depsMakefile used to build the FMS depedency. The autoconf compilation is now done entirely outside of theac/deps/fms/srcdirectory. This keeps the FMS checkout unchanged and allows us to better track any development changes in that library during development.The .testing/Makefile was also modified to use existing rules in deps/Makefile rather than duplicating them.