Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Set_interp_answer_date and REGRIDDING_ANSWER_DATE #369

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

Hallberg-NOAA
Copy link
Member

Add the ability to set the answer date for the regridding code, including the addition of the new subroutine set_interp_answer_date() and the new runtime parameter REGRIDDING_ANSWER_DATE to specify the code vintage to use with state- dependent vertical coordinates. There is also new optional argument to set_regrid_params(). By default, all answers are bitwise identical, but there are new or modified public interfaces and there is a new entry in some MOM_parameter_doc files.

  Add the ability to set the answer date for the regridding code, including the
addition of the new subroutine set_interp_answer_date and the new runtime
parameter REGRIDDING_ANSWER_DATE to specify the code vintage to use with state-
dependent vertical coordinates.  There is also new optional argument to
set_regrid_params.  By default, all answers are bitwise identical, but there are
new or modified public interfaces and there is a new entry in some
MOM_parameter_doc files.
@Hallberg-NOAA Hallberg-NOAA added enhancement New feature or request Parameter change Input parameter changes (addition, removal, or description) labels May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #369 (c1dbdfe) into dev/gfdl (53e9361) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c1dbdfe differs from pull request most recent head cd02bc8. Consider uploading reports for the commit cd02bc8 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #369      +/-   ##
============================================
- Coverage     38.29%   38.28%   -0.01%     
============================================
  Files           269      269              
  Lines         76012    76018       +6     
  Branches      13981    13982       +1     
============================================
- Hits          29108    29107       -1     
- Misses        41677    41682       +5     
- Partials       5227     5229       +2     
Impacted Files Coverage Δ
src/ALE/MOM_regridding.F90 28.63% <0.00%> (-0.10%) ⬇️
src/ALE/regrid_interp.F90 1.47% <0.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Member

Assuming this will be utilized for upcoming work.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19416 ✔️ 🟡

@marshallward marshallward merged commit 1faa9ab into NOAA-GFDL:dev/gfdl Jun 6, 2023
@Hallberg-NOAA Hallberg-NOAA deleted the regrid_answer_date branch August 23, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Parameter change Input parameter changes (addition, removal, or description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants