-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrostatic initialization in ice cavities #41
Hydrostatic initialization in ice cavities #41
Conversation
MJHarrison-GFDL
commented
Dec 14, 2021
•
edited
Loading
edited
- Iteratively solve for the initial ice shelf displacement in cavities by calculating the pressure at the current displacement depth using the unperturbed profile. - This change should obsolete TRIM_IC_FOR_PSURF and DEPRESS_INITIAL_SURFACE for ice shelf applications and should work for arbitrary equations of state. - Existing implementations (e.g. ISOMIP) should turn off the above options in order to exercise this feature. - This code change should not impact non ice-shelf configurations or those with either of the above two options.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #41 +/- ##
============================================
- Coverage 28.85% 28.82% -0.03%
============================================
Files 242 242
Lines 71422 71495 +73
============================================
+ Hits 20609 20612 +3
- Misses 50813 50883 +70
Continue to review full report at Codecov.
|
This PR is built on top of the changes in MOM6 PR #35, so it should be dealt with after the issues noted with that predecessor PR have been addressed. |
@MJHarrison-GFDL Can you resolve the conflicts when you get a chance? |
@Hallberg-NOAA did you want to review this? Or would someone else be better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the direction where this PR is going, but I have a number of minor changes that I would like to see made (as spelled out in a series of individual comments) before I think that this PR should be merged into dev/gfdl.
…4 into static_ice_shlf_init
This PR has passed the TC testing and the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14508. Unfortunately, it changes the order of some entries in numerous MOM_parameter_doc.all files, so these will have to be updated in MOM6-examples as well. |