-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data table documentation #551
Data table documentation #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition to our documentation. I had one clarifying comment, but I think this is ready to be added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #551 +/- ##
=========================================
Coverage 37.19% 37.19%
=========================================
Files 271 271
Lines 80346 80346
Branches 14982 14982
=========================================
Hits 29887 29887
Misses 44902 44902
Partials 5557 5557 ☔ View full report in Codecov by Sentry. |
Thank you @ashjbarnes, someone within GFDL just asked me for something like this a few weeks ago. I think this will certainly be appreciated by others. |
This does not run the model so no regression testing is required. These three commits will be squash-merged. |
I've added a summary of how to use the
data_table
to theforcing
page of the docs. I think this might be helpful for new users, as otherwise they need to know to look in the FMS / data_override repository and find the readme there.