Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data table documentation #551

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

ashjbarnes
Copy link

I've added a summary of how to use the data_table to the forcing page of the docs. I think this might be helpful for new users, as otherwise they need to know to look in the FMS / data_override repository and find the readme there.

Copy link

@theresa-cordero theresa-cordero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition to our documentation. I had one clarifying comment, but I think this is ready to be added.

docs/forcing.rst Show resolved Hide resolved
docs/forcing.rst Show resolved Hide resolved
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17f1c40) 37.19% compared to head (ca89042) 37.19%.

Additional details and impacted files
@@            Coverage Diff            @@
##           dev/gfdl     #551   +/-   ##
=========================================
  Coverage     37.19%   37.19%           
=========================================
  Files           271      271           
  Lines         80346    80346           
  Branches      14982    14982           
=========================================
  Hits          29887    29887           
  Misses        44902    44902           
  Partials       5557     5557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marshallward
Copy link
Member

Thank you @ashjbarnes, someone within GFDL just asked me for something like this a few weeks ago. I think this will certainly be appreciated by others.

@marshallward
Copy link
Member

This does not run the model so no regression testing is required.

These three commits will be squash-merged.

@marshallward marshallward merged commit 435ccaa into NOAA-GFDL:dev/gfdl Jan 29, 2024
12 checks passed
@ashjbarnes ashjbarnes deleted the data_table-documentation branch January 30, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants