(*)non-Boussinesq Z unit update_OBC_segment_data #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #552 +/- ##
=========================================
Coverage 37.20% 37.20%
=========================================
Files 271 271
Lines 80475 80473 -2
Branches 15008 15008
=========================================
+ Hits 29942 29943 +1
+ Misses 44961 44958 -3
Partials 5572 5572 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
force-pushed
the
nonBous_OBC_input
branch
from
726e9b0 to
d77fe7c
Compare
|
This pull request was amended to also add descriptions of 25 internal variables in this module or their units, and to correct a number of instances of code that did not adhere to the guidance in the MOM_style_guide. |
Revised the update_OBC_segment_data code to keep the z-space input data in height units ([Z ~> m]) rather than rescaling them to thickness units. This change means that the non-Boussinesq open boundary condition calculations avoid using the Boussinesq reference density. Associated with this change, 5 internal variables in update_OBC_segment_data were renamed to reflect that they are layer vertical extents instead of thicknesses. Also added or amended comments describing the purpose and units of 25 real variables in this module and corrected a handful of lines in this module that were not adhering to the guidance in the MOM6 style guide. Answers are bitwise identical in any Boussinesq cases. However, answers will change in any non-Boussinesq cases that use open boundary conditions that use time_interp_extrnal to read in Z-space data.
Hallberg-NOAA
force-pushed
the
nonBous_OBC_input
branch
from
d77fe7c to
b1f8d78
Compare
marshallward
approved these changes
Feb 29, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22488 ✔️ |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised
update_OBC_segment_data()to keep the z-space input data in height units ([Z ~> m]) rather than rescaling them to thickness units. This change means that the non-Boussinesq open boundary condition calculations avoid using the Boussinesq reference density. Associated with this change, 5 internal variables inupdate_OBC_segment_data()were renamed to reflect that they are layer vertical extents instead of thicknesses. Answers are bitwise identical in any Boussinesq cases. However, answers will change in any non-Boussinesq cases that use open boundary conditions that usetime_interp_extrnal()to read in Z-space data.