*Fix two bugs in convert_temp_salt_for_TEOS10 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed two bugs on a single line of convert_temp_salt_for_TEOS10. The first bug was a reversal in the order of the temperature and salinity arguments to poTemp_to_consTemp, resulting in temperatures that closely approximate the salinities. The second bug that was fixed on this line was temperatures being rescaled with a factor that is appropriate for salinities. This bug-fix will change answers dramatically for any cases that use the ROQUET_RHO, ROQUET_SPV and TEOS10 equations of state and initialize the model with INIT_LAYERS_FROM_Z_FILE = True.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #560 +/- ##
=========================================
Coverage 37.21% 37.21%
=========================================
Files 271 271
Lines 80405 80405
Branches 14992 14992
=========================================
Hits 29925 29925
Misses 44919 44919
Partials 5561 5561 ☔ View full report in Codecov by Sentry. |
jkrasting
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
@Hallberg-NOAA - I tested this fix in a candidate configuration of OM5. It corrects the initialization error caused by the improper ordering of arguments to poTemp_to_consTemp() and not using the C_to_degC scaling term for temperature.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22237 ✔️ |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs on a single line of
convert_temp_salt_for_TEOS10(). The first bug was a reversal in the order of the temperature and salinity arguments topoTemp_to_consTemp(), resulting in temperatures that closely approximate the salinities. The second bug that was fixed on this line was temperatures being rescaled with a factor that is appropriate for salinities. This bug-fix will change answers dramatically for any cases that use theROQUET_RHO,ROQUET_SPVandTEOS10equations of state and initialize the model withINIT_LAYERS_FROM_Z_FILE = True.