Document remapping function variable units #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #569 +/- ##
============================================
- Coverage 42.95% 37.14% -5.81%
============================================
Files 41 271 +230
Lines 5033 80726 +75693
Branches 956 15061 +14105
============================================
+ Hits 2162 29988 +27826
- Misses 2686 45141 +42455
- Partials 185 5597 +5412 ☔ View full report in Codecov by Sentry. |
Closed
Hallberg-NOAA
force-pushed
the
remap_function_units
branch
from
00d88d2 to
3ddfe44
Compare
|
This PR has been expanded to include documentation of the units of a total of about 212 variables in 11 remapping and ALE modules. |
Hallberg-NOAA
force-pushed
the
remap_function_units
branch
from
3ddfe44 to
7e94508
Compare
|
This PR has been expanded again to include documentation of the units of a total of about 282 variables in 12 remapping and ALE modules. |
Added or amended comments to document the mostly arbitrary units of about 360 variables in 13 low-level remapping modules. Only comments are changed and all answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
remap_function_units
branch
from
7e94508 to
638bbe3
Compare
marshallward
approved these changes
Mar 13, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22609 ✔️ |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or amended comments to document the mostly arbitrary units of about 108 variables in 5 low-level remapping modules. Only comments are changed and all answers are bitwise identical.