Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to the descriptions of 115 variables #586

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

Hallberg-NOAA
Copy link
Member

Added or corrected the units in comments describing about 115 real variables scattered across 14 tracer modules and 10 other modules. All answers are bitwise identical, and only comments are changed.

@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.11%. Comparing base (43b2a43) to head (731e02b).

❗ Current head 731e02b differs from pull request most recent head 3b3ea46. Consider uploading reports for the commit 3b3ea46 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #586      +/-   ##
============================================
+ Coverage     37.07%   37.11%   +0.03%     
============================================
  Files           271      271              
  Lines         80968    80841     -127     
  Branches      15118    15096      -22     
============================================
- Hits          30021    30005      -16     
+ Misses        45324    45225      -99     
+ Partials       5623     5611      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify every unit in situ, but they all seem reasonable.

Someday, we might want to distinguish between real time (CPU time) and model time,

@marshallward
Copy link
Member

@Hallberg-NOAA There is a minor conflict here after the merge from main.

  Added or corrected the units in comments describing about 115 real variables
scattered across 14 tracer modules and 10 other modules.  All answers are
bitwise identical, and only comments are changed.
@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23098 ✔️

@marshallward marshallward merged commit b98acd8 into NOAA-GFDL:dev/gfdl Apr 13, 2024
9 of 10 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the scattered_units branch May 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants