(*)Pass dz to user initialize_ALE_sponge calls #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass vertical extents (dz in [Z ~> m]) instead of thicknesses (h in [H ~> m or kg m-2] and use data_h_is_Z flag in calls to initialize_ALE_sponge calls from 5 user modules and avoid extra calls to dz_to_thickness in these routines. All Boussinesq solutions are bitwise identical, but in any non-Boussinesq configurations using ALE sponges, the previous conversion from dz to thickness and back again can change dz in the last bits, so some non-Boussinesq answers could change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #587 +/- ##
============================================
+ Coverage 37.06% 37.15% +0.08%
============================================
Files 271 271
Lines 80990 80712 -278
Branches 15123 15059 -64
============================================
- Hits 30022 29986 -36
+ Misses 45346 45128 -218
+ Partials 5622 5598 -24 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Apr 9, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23039 ✔️ Reported parameter diff is due to earlier content. |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass vertical extents (
dzin[Z ~> m]) instead of thicknesses (hin[H ~> m or kg m-2]and usedata_h_is_Zflag in calls toinitialize_ALE_sponge()calls from 5 user modules and avoid extra calls todz_to_thickness()in these routines. All Boussinesq solutions are bitwise identical, but in any non-Boussinesq configurations using ALE sponges, the previous conversion fromdzto thickness and back again can changedzin the last bits, so some non-Boussinesq answers could change.