Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FMS1 for MacOS builds #642

Merged
merged 1 commit into from
May 20, 2024
Merged

Use FMS1 for MacOS builds #642

merged 1 commit into from
May 20, 2024

Conversation

adcroft
Copy link
Member

@adcroft adcroft commented May 20, 2024

(This commit was added to gfdl-to-main-2024-05-16 and adding it to dev/gfdl will resolve the red-X we how on our own PRs)

  • Given a recent incompatibility with FMS2 and gfortran 14.1 we need to revert to FMS1 for the MacOS builds.

- Given a recent incompatibility with FMS2 and gfortan 14.1
  we need to revert to FMS1 for the MacOS builds.
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.00%. Comparing base (6272bbc) to head (7d322d2).

Additional details and impacted files
@@            Coverage Diff            @@
##           dev/gfdl     #642   +/-   ##
=========================================
  Coverage     37.00%   37.00%           
=========================================
  Files           271      271           
  Lines         81198    81198           
  Branches      15145    15145           
=========================================
  Hits          30044    30044           
  Misses        45526    45526           
  Partials       5628     5628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we'll remember to fix the true problem.

@marshallward marshallward merged commit 7a2a33b into dev/gfdl May 20, 2024
22 checks passed
@marshallward marshallward deleted the gfdl-to-main-2024-05-16 branch May 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants