+Refactor writing the vertical_coordinate file #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange how the vertical_coordinate file is written, to avoid an unnecessary repetition of the writing of this file, and to prepare for the Hybgen grid generator code to write its own version of this file. The specific changes include: - Added the new subroutine write_regrid_file() to write the vertical_coordinate file when in ALE mode. - Relocated the code to write the vertical_coordinate file in ALE mode from ALE_writeCoordinateFile to write_regrid_file() - Moved the call to write_vertgrid_file() into initialize_MOM(), and do not call it when USE_REGRIDDING=True, since in this case this file will be rewritten again when write_regrid_file() is called. - Eliminated the write_geom and output_dir arguments to MOM_initialize_coord() All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #96 +/- ##
=========================================
Coverage 28.98% 28.98%
=========================================
Files 246 246
Lines 72348 72354 +6
=========================================
+ Hits 20967 20970 +3
- Misses 51381 51384 +3
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/76206 ✔️ 🟡 The location of |
marshallward
approved these changes
Apr 1, 2022
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange how the vertical_coordinate file is written, to avoid an unnecessary
repetition of the writing of this file, and to prepare for the Hybgen grid
generator code to write its own version of this file. The specific changes
include:
Added the new subroutine write_regrid_file() to write the vertical_coordinate
file when in ALE mode.
Relocated the code to write the vertical_coordinate file in ALE mode
from ALE_writeCoordinateFile to write_regrid_file()
Moved the call to write_vertgrid_file() into initialize_MOM(), and do not
call it when USE_REGRIDDING=True, since in this case this file will be
rewritten again when write_regrid_file() is called.
Eliminated the write_geom and output_dir arguments to MOM_initialize_coord()
All answers and output are bitwise identical.