Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating sea ice melt/formation from liquid precipitation field #214
base: dev/gfdl
Are you sure you want to change the base?
Separating sea ice melt/formation from liquid precipitation field #214
Changes from 3 commits
1c8dc7e
ec559ba
5ecae71
49a2829
9b49d6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to reproduce old answers, I think this should be okay, since
IOF%seaice_melt
andnet_melt
are the same. Right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a bug fix flag here will work to get the old diagnostics, but it would be ideal (in my opinion) if there was a way to save
sea ice melt
andsea ice melt + lprec
from the same simulation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add parentheses to specify the order with which
IOF%seaice_melt
is added to the other fields so that this diagnostic does not capriciously change with the level of optimization.My preference would be for
IOF%seaice_melt
to be added first toIOF%lprec_ocn_top
so that the answers more closely resemble what was done previously, but other options could be justified as long as the order of arithmetic is specified unambiguously.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Hallberg-NOAA; I've started to make the necessary changes wherever
fluxes%lprec
shows up.I am not sure what to do here:
https://github.com/NOAA-GFDL/MOM6/blob/37d1385b2979a453c5b2c24d91bbea7c74c6a82e/src/core/MOM_forcing_type.F90#L2275
Is there any way to separately increment these averages for
fluxes%lprec
andfluxes%seaice_melt
while preserving the overall order of operations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, in any
if associated(fluxes%lprec)
blocks, do I need to separately treat the two cases ofif associated(fluxes%seaice_melt)
?