Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow virtual flux correction based on ocean salt restoring/correction #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dougiesquire
Copy link

@dougiesquire dougiesquire commented Jul 24, 2024

This PR implements changes that allow stf adjustments based on any salt restoring/correction applied by the ocean model. There are two changes in this PR:

  • A generic_tracer::generic_tracer_update_from_coupler routine has been added. This receives the salt flux restoring/correction applied by the ocean and passes it on to the generic tracer's update_from_coupler routine.
  • An optional input flux_virtual has been added to the generic_tracer_utils::g_tracer_add routine. If true, this ensures that the stf field is allocated on the tracer being added.

Unfortunately, changes are needed to the calling ocean model in order to utilize the changes in this PR:

  • In MOM5, the existing call to generic_tracer::generic_tracer_coupler_get is replaced by a call to generic_tracer::generic_tracer_coupler_accumulate and then generic_tracer::generic_tracer_update_from_coupler is called as part of ocean_sbc_mod::flux_adjust. See here for the changes.
  • In MOM6, the salt flux added is accumulated and generic_tracer::generic_tracer_update_from_coupler is called in MOM_generic_tracer::MOM_generic_tracer_column_physics. See here for the changes.

Merging this PR but not changing the ocean model will mean no change from current behaviour.

Closes #32

…c_?_update_from_coupler routine

Allow virtual tracer flux adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to account for surface salt restoring fluxes?
1 participant