Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl/develop from main 2021/05/21 #89

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
100a646
Cleanup trailing whitespace for some new added/modified source code r…
BinLiu-NOAA Jun 24, 2020
a8265eb
Merge pull request #4 from hafs-community/feature/merge_hwrf_physics
climbfuji Jun 25, 2020
c13b36d
Merge pull request #2 from climbfuji/update_hafs_from_dtc_hwrf_physic…
climbfuji Jun 26, 2020
8f34789
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Jul 2, 2020
53fc0ff
In GFS_rrtmg_pre.F90, separate out the imp_physics == 6 option and le…
BinLiu-NOAA Jul 8, 2020
81b1ba2
Merge remote-tracking branch 'remotes/upstream/master' into feature/s…
BinLiu-NOAA Jul 8, 2020
643ede9
Merge remote-tracking branch 'remotes/upstream/master' into feature/s…
BinLiu-NOAA Jul 8, 2020
a1f0373
Merge branch 'feature/sync_master_20200703' of https://github.com/haf…
BinLiu-NOAA Jul 8, 2020
0a8bd93
Initialize crtlame properly in physics/samfdeepcnv.f.
BinLiu-NOAA Jul 9, 2020
b6dd33b
Merge remote-tracking branch 'remotes/upstream/master' into feature/s…
BinLiu-NOAA Jul 16, 2020
1b400f5
Follow the master branch to change the unit of radians into radian in
BinLiu-NOAA Jul 17, 2020
370e3a9
change hard-coded dimensions to assumed sizes
XiaSun-Atmos Aug 24, 2020
1870133
delete personal experimental files
XiaSun-Atmos Aug 24, 2020
d930025
Merge remote-tracking branch 'upstream/master' into assumedsizes
XiaSun-Atmos Aug 24, 2020
feb3973
Changes to fortran and metadata tables to pass capgen consistency check.
Aug 31, 2020
b61a3b9
Merge branch 'master' into capgen_fixes
Aug 31, 2020
ee38a14
Fixes for intent mismatch, out of order arguments and subroutines
Sep 1, 2020
c52a094
More fixes to intent mismatches, no matching Fortran routine found,
Sep 2, 2020
b267bc8
Merge branch 'master' into capgen_fixes
Sep 2, 2020
3b63fdb
Merge branch 'master' into assumedsizes
XiaSun-Atmos Oct 1, 2020
3a834f9
Merge remote-tracking branch 'upstream/master' into support/HAFS
BinLiu-NOAA Nov 24, 2020
65c96f0
Merge branch 'master' into capgen_fixes
Nov 30, 2020
d07d53b
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Dec 12, 2020
85fa557
Rearrange metadata table entries and add intent to keep capgen happy.
Jan 5, 2021
ad9e16d
Merge branch 'master' into capgen_fixes
Jan 5, 2021
8e7e1b7
Fix order of variables and differing intents.
Jan 6, 2021
72b01ad
Fix CCPPError: No matching Fortran routine found for sfc_sice_run
Jan 6, 2021
dc0f118
Add missing intent statements
Jan 7, 2021
2345803
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Jan 7, 2021
746cb5b
Merge commit '13b8889' used by ufs-weather-model as of 20210120 into …
BinLiu-NOAA Jan 21, 2021
c0ac40b
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Feb 2, 2021
d6cf638
Merge branch 'master' into capgen_fixes
Feb 4, 2021
7cbb6ae
Change intent from out to inout to match fortran.
Feb 4, 2021
048d605
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Feb 16, 2021
373ac91
Initial commit
dustinswales Feb 23, 2021
c985cee
Initial commit. Save temperature from previous timestep when using RR…
dustinswales Mar 1, 2021
3ff716e
Merge branch 'master' into capgen_fixes
Mar 2, 2021
7a1373f
Merge branch 'master' into capgen_fixes
Mar 3, 2021
1223d7a
Fix intent statements as requested by Dom.
Mar 3, 2021
7aee096
Jacobian of LW (Up/Down) applied to adjustment of radiation tendency …
dustinswales Mar 4, 2021
1d598ee
Bug fixes for l127 configuration using RRTMGP
dustinswales Mar 4, 2021
4e85c8b
Changes to metadata.
dustinswales Mar 4, 2021
bc460cc
Merge remote-tracking branch 'upstream/hotfix_tlay_for_c768l127' into…
dustinswales Mar 4, 2021
0fd915f
Some small changes
dustinswales Mar 4, 2021
ae4e43a
A bug fix related NSST model in the coupled mode and a reduction of z…
XuLi-NOAA Mar 5, 2021
8020395
Modifed sfc_nst.meta (related to the update in sfc_nst.f)
XuLi-NOAA Mar 5, 2021
0c37afd
Full profile LW flux adjustment using RRTMGP Jacobians.
dustinswales Mar 5, 2021
55d395f
Updated sfc_nst.f, sfc_nst.meta, module_nst_water_prop.f90 and flake_…
YihuaWu-NOAA Mar 8, 2021
049fdbe
Removed redundant code.
dustinswales Mar 8, 2021
0aa3bfc
Merge remote-tracking branch 'upstream/add_RRFS_to_GP' into addLWadj_…
dustinswales Mar 8, 2021
d550e98
Added adjustment with Jacobian to surface flux, used for coupling.
dustinswales Mar 9, 2021
568c65b
Pass cloud-fraction through GP-2-mpinterfaces when using SGS clouds.
dustinswales Mar 11, 2021
84dcabc
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ad…
dustinswales Mar 11, 2021
97f409e
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Mar 12, 2021
8c60ce5
Remove/replace interstitial zorl composites with persistent versions
climbfuji Mar 17, 2021
f1d12c5
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji Mar 17, 2021
20e1ae8
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji Mar 18, 2021
26340ba
Updated sfc_nst.f & sfc_nst.meta
YihuaWu-NOAA Mar 18, 2021
17ccdcf
Updated sfc_nst.f to remove unnecessary statements
YihuaWu-NOAA Mar 18, 2021
c94849f
Updated rte-rrtmgp hash
dustinswales Mar 18, 2021
9a338f1
physics/rrtmgp_aux.F90: fix bug for integer variable that should be a…
climbfuji Mar 19, 2021
dbd65a8
CMakeLists.txt: compile certain files without OpenMP
climbfuji Mar 19, 2021
f814c92
Merge pull request #15 from climbfuji/rrtmgp_noopenmp_dom
dustinswales Mar 19, 2021
4e9b59a
Moved allocation of LW interstitials to GFS_typedefs. Removed downwar…
dustinswales Mar 24, 2021
89e84b3
physics/docs directory updates from release/public-v5
Mar 24, 2021
0f50802
Merge pull request #540 from climbfuji/release_public_v2_gnu10_crashes
climbfuji Jan 5, 2021
6406fee
Merge remote-tracking branch 'upstream/master' into feature/ufs-nst
XuLi-NOAA Mar 24, 2021
cfa8bf9
Merge pull request #576 from grantfirl/remove_gmtb
grantfirl Feb 22, 2021
ccdffcf
Merge pull request #577 from grantfirl/csawmg_related_GFS_MP_generic_…
climbfuji Feb 23, 2021
5b38f90
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales Mar 24, 2021
54705a0
Change inout to be in for 6 variables (xt,xz ...) in post run
XuLi-NOAA Mar 25, 2021
ad4515a
Moved assignment of spectral information from _init()'s to _run() for…
dustinswales Mar 26, 2021
8b0a7d3
Merge remote-tracking branch 'upstream/master' into feature/ufs-nst
XuLi-NOAA Mar 31, 2021
094d39c
Merge remote-tracking branch 'remotes/upstream/master' into support/HAFS
BinLiu-NOAA Mar 31, 2021
c650fc3
Merge remote-tracking branch 'upstream/master' into feature/ufs-nst
XuLi-NOAA Mar 31, 2021
6f9c83e
Merge remote-tracking branch 'upstream/master' into support/HAFS
BinLiu-NOAA Apr 1, 2021
0ee9504
Merge remote-tracking branch 'upstream/master' into flake
YihuaWu-NOAA Apr 1, 2021
465167f
Removed a line not needed
YihuaWu-NOAA Apr 1, 2021
8f78249
Added comments to briefily describe some temporary variables in the code
YihuaWu-NOAA Apr 1, 2021
68bf580
Speed up aeerosol interpolation and Noah MP initialization using OpenMP
climbfuji Apr 2, 2021
15575af
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into th…
climbfuji Apr 2, 2021
c8b70e9
physics/GFS_debug.*: add roughness length variables to GFS_checkland
climbfuji Apr 2, 2021
f4cf862
Cleanup formatting and unused variables in physics/GFS_suite_intersti…
climbfuji Apr 2, 2021
9143484
Add dkudiagnostic in moninedmf from Andy Hazelton.
BinLiu-NOAA Apr 2, 2021
347104a
physics/GFS_phys_time_vary.fv3.F90: remove variable that was used for…
climbfuji Apr 2, 2021
edc9194
Temporary commit: conditionally set zorlx variables to huge in GFS_su…
climbfuji Apr 2, 2021
bc78c25
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into re…
climbfuji Apr 2, 2021
267748a
Rename Fortran variables and CCPP standard names / long names of surf…
climbfuji Apr 5, 2021
3f953f5
physics/GFS_debug.F90: rename Sfcprop%zorlw to Sfcprop%zorlwav, remov…
climbfuji Apr 5, 2021
7f42a8f
Merge branch 'remove_zorl_interstitial' of https://github.com/climbfu…
climbfuji Apr 5, 2021
7f70536
physics/GFS_debug.*: rename land surface composite DDT members from _…
climbfuji Apr 5, 2021
c6f9c79
Merge branch 'master' into capgen_fixes
Apr 6, 2021
bfa9a65
Fix more out of order variables and mismatched intents.
Apr 6, 2021
edd817a
Merge branch 'assumedsizes' of https://github.com/xiasun-noaa/ccpp-ph…
climbfuji Apr 6, 2021
a8e6ec9
Convert explicit dimensions of intent(in) variables to assumed-size d…
climbfuji Apr 7, 2021
52bf572
Bugfix for precipitation quantities, fix Fortran/metadata inconsisten…
climbfuji Apr 7, 2021
990b9d0
Merge pull request #589 from XuLi-NOAA/feature/ufs-nst
climbfuji Apr 8, 2021
222ffe6
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into th…
climbfuji Apr 9, 2021
56c8d3a
Do not use OpenMP in physics/aerinterp.F90 with gfortran (compatibili…
climbfuji Apr 9, 2021
6b99742
Bugfix in physics/GFS_phys_time_vary.fv3.F90, add missing 'if (iaercl…
climbfuji Apr 9, 2021
ead8bd6
Bugfixes for GP/ThompsonMP coupling
dustinswales Apr 9, 2021
fdcff10
fix bug in UGWPv0 where it was using the wrong arguments in a oro_wam…
grantfirl Apr 9, 2021
cc85d94
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales Apr 9, 2021
efbca16
fix another call with the wrong number of arguments caught by the SCM…
grantfirl Apr 9, 2021
c86bb23
Fix conflict bug from previous merge.
dustinswales Apr 9, 2021
486db7c
CCPPv5.0.0 scientific documentation sync
mzhangw Apr 9, 2021
3959ba8
doc updates
mzhangw Apr 9, 2021
4522e6b
doc updates 2
mzhangw Apr 9, 2021
87528e1
Merge pull request #2 from mzhangw/scidocv5_sync
llpcarson Apr 12, 2021
334e245
Updating to head of upstream
YihuaWu-NOAA Apr 12, 2021
7adb61f
Fixed conflicts
YihuaWu-NOAA Apr 12, 2021
e1f6417
Fixed errors created during merge processes
YihuaWu-NOAA Apr 13, 2021
6a08c3a
Fixed some code errors caused during merging processes
YihuaWu-NOAA Apr 13, 2021
dfeb51c
Merge branch 'flake' of https://github.com/YihuaWu-NOAA/ccpp-physics …
YihuaWu-NOAA Apr 13, 2021
a81cdb9
Corrected merge error
YihuaWu-NOAA Apr 13, 2021
2742ece
Merge branch 'flake' of https://github.com/YihuaWu-NOAA/ccpp-physics …
YihuaWu-NOAA Apr 13, 2021
de88abb
merge bug-fix
Apr 13, 2021
5411d4d
Fixed some issues
YihuaWu-NOAA Apr 13, 2021
1f8c2da
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into up…
Apr 13, 2021
8cd133d
Modified code based on Moorthi's commits: recoded the polynomial equ…
YihuaWu-NOAA Apr 14, 2021
e46fe37
Merge branch 'rename_surface_composites_ocean_water' of https://githu…
climbfuji Apr 14, 2021
80ae761
Recoded the polynomial equation and redefined lake as use_flake
YihuaWu-NOAA Apr 14, 2021
bc75cd5
Merge branch 'flake' of https://github.com/YihuaWu-NOAA/ccpp-physics …
YihuaWu-NOAA Apr 14, 2021
26aa3d6
Merge pull request #623 from climbfuji/zorl_ocnwat_merra2_combined
climbfuji Apr 15, 2021
b39b313
Convert more explicit dimensions of argument variables to assumed-siz…
climbfuji Apr 7, 2021
b0cebc2
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ca…
climbfuji Apr 15, 2021
e20ad29
Corrected the orders of three parameters
YihuaWu-NOAA Apr 15, 2021
aa73104
Updated to head of upstream
YihuaWu-NOAA Apr 15, 2021
3163fbc
Merge branch 'flake' of https://github.com/YihuaWu-NOAA/ccpp-physics …
YihuaWu-NOAA Apr 15, 2021
24ce7d6
scidoc fix
mzhangw Apr 15, 2021
59ab0cd
Updated flake physics
YihuaWu-NOAA Apr 15, 2021
8a27681
change version # from 5 to 1 per agreement with NCAR colleagues
mzhangw Apr 15, 2021
2ce81df
Merge remote-tracking branch 'upstream/master' into feature/dkudiagno…
BinLiu-NOAA Apr 16, 2021
5f73158
Update error messaging in sfcsub.F to conform to NCEP/NCO
GeorgeGayno-NOAA Apr 16, 2021
046f585
use new syntax in SDF files
mzhangw Apr 16, 2021
495536d
Merge pull request #3 from mzhangw/pr-626
llpcarson Apr 16, 2021
8c44643
*Rename dkudiagnostic into dku in moninedmf.f and satmedmfvdifq.F.
BinLiu-NOAA Apr 16, 2021
b53829d
Updated flake physics
YihuaWu-NOAA Apr 16, 2021
b657923
Merge branch 'flake' of https://github.com/YihuaWu-NOAA/ccpp-physics …
YihuaWu-NOAA Apr 16, 2021
4c84630
Use unique standard_name for the new added dkt and dku diagnostic var…
BinLiu-NOAA Apr 16, 2021
2d3b3c4
Reserved a part of the code
YihuaWu-NOAA Apr 16, 2021
b80f88f
Fix formatting/revert unnecessary formatting changes
climbfuji Apr 16, 2021
67ddd4f
Fix compile errors in sfc_nst.f and sfc_nst.meta
climbfuji Apr 16, 2021
045785a
Merge pull request #629 from climbfuji/flake_from_yihua
climbfuji Apr 19, 2021
76d879b
Merge pull request #1 from NCAR/master
matusmartini Apr 19, 2021
7fa34d5
physics/mp_thompson.F90: move 'max' checks where they belong
climbfuji Apr 19, 2021
c9bdbb8
Revert assumed-size array changes in physics/gfdl_fv_sat_adj.F90, fix…
climbfuji Apr 19, 2021
8bf5802
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ca…
climbfuji Apr 19, 2021
c071241
ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with dia…
mdtoyNOAA Apr 19, 2021
eed0761
Fix array-out-of-bounds errors when extra top layer is used for press…
matusmartini Apr 20, 2021
28c815a
Unify the usage of Diag%dkt and Interstitial%dkt and change the stand…
BinLiu-NOAA Apr 20, 2021
7b7eb85
Merge remote-tracking branch 'remotes/upstream/master' into feature/d…
BinLiu-NOAA Apr 20, 2021
0beed6e
bug fix for doxygen
Apr 20, 2021
073fbe8
Merge branch 'master' into feature/sfcsub_errmsg
GeorgeGayno-NOAA Apr 21, 2021
3dbae5d
Merge pull request #607 from hafs-community/feature/dkudiagnostic
climbfuji Apr 21, 2021
f29be0c
Merge branch 'ltp-bugfix' of https://github.com/matusmartini/ccpp-phy…
climbfuji Apr 22, 2021
6b8203f
Merge branch 'ugwpv1_gsldrag_bugfixes_etc' of https://github.com/mdto…
climbfuji Apr 22, 2021
1734de0
Merge branch 'feature/sfcsub_errmsg' of https://github.com/GeorgeGayn…
climbfuji Apr 22, 2021
54d8f07
Merge branch 'ugwpv0_dependency_fix' of https://github.com/grantfirl/…
climbfuji Apr 22, 2021
048b2e1
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into up…
Apr 22, 2021
d194af6
Bugfix in physics/mp_thompson.F90: need to call mp_gt_driver with or …
climbfuji Apr 22, 2021
5b8973f
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ca…
climbfuji Apr 22, 2021
1d0e6ed
fix merge-error
Apr 22, 2021
b35cf89
Fix formattting in physics/mp_thompson_post.F90
climbfuji Apr 22, 2021
8c4e010
Change vertical dimension of arrays atmosphere_heat_diffusivity (aka …
climbfuji Apr 23, 2021
330f971
Added default values in RRTMGP sw gas-optics initialization routine. …
dustinswales Apr 23, 2021
0cdc94b
Some housekeeping in GP-ThompsonMP interface.
dustinswales Apr 23, 2021
ff590a7
Added call to compute_optimal_angle call before rte_lw(). New field p…
dustinswales Apr 23, 2021
75cd6eb
Added ngauss_angles back into rte_lw() clear-sky calculation.
dustinswales Apr 23, 2021
a91a5cf
Updated rte-rrtmgp submodule.
dustinswales Apr 23, 2021
b578157
Merge pull request #626 from llpcarson/updates_from_v2
climbfuji Apr 26, 2021
f360464
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into co…
climbfuji Apr 26, 2021
dd9b7b5
Cleanup from PR.
dustinswales Apr 27, 2021
e39824a
Removed call to compute_heating_rate. Compute in-line.
dustinswales Apr 27, 2021
ead39d1
Merge pull request #641 from climbfuji/collect_various_prs_20210422
climbfuji Apr 28, 2021
64b6fae
Changes from code review
dustinswales Apr 28, 2021
d52656b
Renamed rrtmgp_aux.F90
dustinswales Apr 28, 2021
aa27739
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales Apr 28, 2021
d2a16dc
Initialize intent(out) atmosphere_heat_diffusivity / atmosphere_momen…
climbfuji Apr 28, 2021
d158c5c
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ca…
climbfuji Apr 28, 2021
033e6b1
Fix bug in physics/GFS_MP_generic.F90 from recent merge
climbfuji Apr 28, 2021
6a9de17
Fix bug in scm_sfc_flux_spec.F90 from recent merge
climbfuji Apr 28, 2021
f3ef953
Reverted deprecated code.
dustinswales Apr 28, 2021
2ff5d1c
Update CMakeLists.txt so that local compiler flag modifications also …
climbfuji Apr 29, 2021
d22cb6d
Merge pull request #16 from climbfuji/cmakelists_symlinks_in_path
dustinswales Apr 29, 2021
1cc8111
update GFS_phys_time_vary.scm.F90 to match FV3 changes
grantfirl Apr 29, 2021
edf5dbc
Merge branch 'SCM_update_20210429' of https://github.com/grantfirl/cc…
climbfuji Apr 29, 2021
05bf214
Merge branch 'addLWadj_fullProfile' of https://github.com/dustinswale…
climbfuji Apr 29, 2021
41d34d0
Bugfix in physics/m_micro.F90: correct calculation of flipped vertica…
climbfuji Apr 29, 2021
5015be4
Merge pull request #614 from dustinswales/addLWadj_fullProfile
climbfuji Apr 30, 2021
1ed27c1
Fix metadata
climbfuji Apr 30, 2021
ffe0057
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ca…
climbfuji Apr 30, 2021
6237270
Merge pull request #611 from climbfuji/capgen_fixes_assumed_sizes
climbfuji Apr 30, 2021
0ab9cd9
Add templates for pull requests and issues.
May 3, 2021
fdb29b4
Fix table format.
May 3, 2021
adf39b8
change variable to assumed-shape since it is conditionally allocated …
grantfirl May 7, 2021
75c2c62
Modify content to allow developers to add links to PRs for testing an…
May 10, 2021
7e0e2a0
Address Dom's comments, hopefully.
May 10, 2021
3c16847
change all arrays to assumed-shape in GFS_suite_interstitial.F90 (plu…
grantfirl May 10, 2021
36486c3
Merge branch 'feature/add_templates' of https://github.com/julieschra…
climbfuji May 12, 2021
144d079
Merge pull request #658 from climbfuji/wrapper_648_652
climbfuji May 18, 2021
94bf989
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
climbfuji May 20, 2021
1da8710
Bug fixes from merge of main into gsl/develop
climbfuji May 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

# Description

Provide a clear and concise description of the bug and what behavior you are expecting.

## Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. step 1
2. step 2
3. see the bug...

## Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

* Machine
* Compiler
* Suite Definition File or Scheme
* Reference other issues or PRs in other repositories that this is related to, and how they are related.

## Output

Please include any relevant log files, screenshots or other output here.
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

## Description
Provide a clear and concise description of the problem to be solved.

## Solution
Add a clear and concise description of the proposed solution.

## Alternatives (optional)
If applicable, add a description of any alternative solutions or features you've considered.

## Related to (optional)
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related.
22 changes: 22 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Description of Changes:
One or more paragraphs describing the problem, solution, and required changes.

## Tests Conducted:
Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit!
**OR** Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model/pull/<pr_number>"

## Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
- NCAR/ccpp-framework/pull/<pr_number>
- NOAA-EMC/fv3atm/pull/<pr_number>
- ufs-community/ufs-weather-model/pull/<pr_number>

## Documentation:
Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.

## Issue (optional):
If this PR is resolving or referencing one or more issues, in this repository or elewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in https://github.com/NCAR/other_repository/pull/63"

## Contributors (optional):
If others have contributed to this work aside from the PR author, list them here

266 changes: 142 additions & 124 deletions CMakeLists.txt

Large diffs are not rendered by default.

55 changes: 26 additions & 29 deletions physics/GFS_DCNV_generic.F90
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ subroutine GFS_DCNV_generic_pre_run (im, levs, ldiag3d, qdiag3d, do_cnvgwd, cplc

integer, intent(in) :: im, levs, nsamftrac, ntqv, index_of_process_dcnv, dtidx(:,:)
logical, intent(in) :: ldiag3d, qdiag3d, do_cnvgwd, cplchm
real(kind=kind_phys), dimension(im,levs), intent(in) :: gu0
real(kind=kind_phys), dimension(im,levs), intent(in) :: gv0
real(kind=kind_phys), dimension(im,levs), intent(in) :: gt0
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: gq0
real(kind=kind_phys), dimension(im,levs), intent(inout) :: save_u
real(kind=kind_phys), dimension(im,levs), intent(inout) :: save_v
real(kind=kind_phys), dimension(im,levs), intent(inout) :: save_t
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: save_q
real(kind=kind_phys), dimension(:,:), intent(in) :: gu0
real(kind=kind_phys), dimension(:,:), intent(in) :: gv0
real(kind=kind_phys), dimension(:,:), intent(in) :: gt0
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: gq0
real(kind=kind_phys), dimension(:,:), intent(inout) :: save_u
real(kind=kind_phys), dimension(:,:), intent(inout) :: save_v
real(kind=kind_phys), dimension(:,:), intent(inout) :: save_t
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: save_q
! dqdti only allocated if cplchm is .true.
real(kind=kind_phys), dimension(:,:), intent(inout) :: dqdti
character(len=*), intent(out) :: errmsg
Expand Down Expand Up @@ -99,8 +99,8 @@ end subroutine GFS_DCNV_generic_post_finalize
!> \section arg_table_GFS_DCNV_generic_post_run Argument Table
!! \htmlinclude GFS_DCNV_generic_post_run.html
!!
subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, ras, cscnv, &
frain, rain1, dtf, cld1d, save_u, save_v, save_t, gu0, gv0, gt0, &
subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, qdiag3d, ras, &
cscnv, frain, rain1, dtf, cld1d, save_u, save_v, save_t, gu0, gv0, gt0, &
ud_mf, dd_mf, dt_mf, con_g, npdf3d, num_p3d, ncnvcld3d, nsamftrac, &
rainc, cldwrk, upd_mf, dwn_mf, det_mf, dtend, dtidx, index_of_process_dcnv, &
index_of_temperature, index_of_x_wind, index_of_y_wind, ntqv, gq0, save_q, &
Expand All @@ -113,31 +113,26 @@ subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, ras, cscnv, &
implicit none

integer, intent(in) :: im, levs, nsamftrac
logical, intent(in) :: lssav, ldiag3d, ras, cscnv
logical, intent(in) :: lssav, ldiag3d, qdiag3d, ras, cscnv
logical, intent(in) :: flag_for_dcnv_generic_tend

real(kind=kind_phys), intent(in) :: frain, dtf
real(kind=kind_phys), dimension(im), intent(in) :: rain1, cld1d
real(kind=kind_phys), dimension(im,levs), intent(in) :: save_u, save_v, save_t
real(kind=kind_phys), dimension(im,levs), intent(in) :: gu0, gv0, gt0
real(kind=kind_phys), dimension(:,:,:), intent(in) :: gq0, save_q
real(kind=kind_phys), dimension(im,levs), intent(in) :: ud_mf, dd_mf, dt_mf
real(kind=kind_phys), dimension(:), intent(in) :: rain1, cld1d
real(kind=kind_phys), dimension(:,:), intent(in) :: save_u, save_v, save_t
real(kind=kind_phys), dimension(:,:), intent(in) :: gu0, gv0, gt0
real(kind=kind_phys), dimension(:,:,:), intent(in) :: gq0, save_q
real(kind=kind_phys), dimension(:,:), intent(in) :: ud_mf, dd_mf, dt_mf
real(kind=kind_phys), intent(in) :: con_g
integer, intent(in) :: npdf3d, num_p3d, ncnvcld3d

real(kind=kind_phys), dimension(im), intent(inout) :: rainc, cldwrk
! dtend, upd_mf, dwn_mf, det_mf only allocated if ldiag3d == .true.
real(kind=kind_phys), dimension(:), intent(inout) :: rainc, cldwrk
real(kind=kind_phys), dimension(:,:), intent(inout) :: upd_mf, dwn_mf, det_mf
real(kind=kind_phys), dimension(im,levs), intent(inout) :: cnvw, cnvc
real(kind=kind_phys), dimension(:,:), intent(inout) :: cnvw, cnvc

real(kind=kind_phys), dimension(:,:,:), intent(inout) :: dtend
integer, intent(in) :: dtidx(:,:), index_of_process_dcnv, index_of_temperature, &
index_of_x_wind, index_of_y_wind, ntqv

! The following arrays may not be allocated, depending on certain flags and microphysics schemes.
! Since Intel 15 crashes when passing unallocated arrays to arrays defined with explicit shape,
! use assumed-shape arrays. Note that Intel 18 and GNU 6.2.0-8.1.0 tolerate explicit-shape arrays
! as long as these do not get used when not allocated (it is still invalid Fortran code, though).
real(kind=kind_phys), dimension(:,:), intent(inout) :: cnvw_phy_f3d, cnvc_phy_f3d

character(len=*), intent(out) :: errmsg
Expand Down Expand Up @@ -209,13 +204,15 @@ subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, ras, cscnv, &
endif

! convective mass fluxes
do k=1,levs
do i=1,im
upd_mf(i,k) = upd_mf(i,k) + ud_mf(i,k) * (con_g*frain)
dwn_mf(i,k) = dwn_mf(i,k) + dd_mf(i,k) * (con_g*frain)
det_mf(i,k) = det_mf(i,k) + dt_mf(i,k) * (con_g*frain)
if(qdiag3d) then
do k=1,levs
do i=1,im
upd_mf(i,k) = upd_mf(i,k) + ud_mf(i,k) * (con_g*frain)
dwn_mf(i,k) = dwn_mf(i,k) + dd_mf(i,k) * (con_g*frain)
det_mf(i,k) = det_mf(i,k) + dt_mf(i,k) * (con_g*frain)
enddo
enddo
enddo
endif
endif ! if (ldiag3d)

endif ! if (lssav)
Expand Down
8 changes: 8 additions & 0 deletions physics/GFS_DCNV_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,14 @@
type = logical
intent = in
optional = F
[qdiag3d]
standard_name = flag_tracer_diagnostics_3D
long_name = flag for 3d tracer diagnostic fields
units = flag
dimensions = ()
type = logical
intent = in
optional = F
[ras]
standard_name = flag_for_ras_deep_convection
long_name = flag for ras convection scheme
Expand Down
19 changes: 14 additions & 5 deletions physics/GFS_GWD_generic.F90
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
!> \file GFS_GWD_generic.f
!> \file GFS_GWD_generic.F90
!! This file contains the CCPP-compliant orographic gravity wave
!! drag pre interstitial codes.

module GFS_GWD_generic_pre

contains

!! \section arg_table_GFS_GWD_generic_pre_init Argument Table
!! \htmlinclude GFS_GWD_generic_pre_init.html
!!
subroutine GFS_GWD_generic_pre_init()
end subroutine GFS_GWD_generic_pre_init

Expand All @@ -29,15 +32,15 @@ subroutine GFS_GWD_generic_pre_run( &
implicit none

integer, intent(in) :: im, levs, nmtvr
real(kind=kind_phys), intent(in) :: mntvar(im,nmtvr)
real(kind=kind_phys), intent(in) :: mntvar(:,:)

real(kind=kind_phys), intent(out) :: &
& oc(im), oa4(im,4), clx(im,4), &
& oc(:), oa4(:,:), clx(:,:), &
& varss(:), ocss(:), oa4ss(:,:), clxss(:,:), &
& theta(im), sigma(im), gamma(im), elvmax(im)
& theta(:), sigma(:), gamma(:), elvmax(:)

logical, intent(in) :: lssav, ldiag3d, flag_for_gwd_generic_tend
real(kind=kind_phys), intent(in) :: dtdt(im,levs), dudt(im,levs), dvdt(im,levs)
real(kind=kind_phys), intent(in) :: dtdt(:,:), dudt(:,:), dvdt(:,:)
! dtend only allocated only if ldiag3d is .true.
real(kind=kind_phys), intent(inout) :: dtend(:,:,:)
integer, intent(in) :: dtidx(:,:), index_of_temperature, &
Expand Down Expand Up @@ -141,6 +144,9 @@ subroutine GFS_GWD_generic_pre_run( &
end subroutine GFS_GWD_generic_pre_run
!> @}

!! \section arg_table_GFS_GWD_generic_pre_finalize Argument Table
!! \htmlinclude GFS_GWD_generic_pre_finalize.html
!!
subroutine GFS_GWD_generic_pre_finalize()
end subroutine GFS_GWD_generic_pre_finalize

Expand Down Expand Up @@ -216,6 +222,9 @@ subroutine GFS_GWD_generic_post_run(lssav, ldiag3d, dtf, dusfcg, dvsfcg, dudt, d
end subroutine GFS_GWD_generic_post_run
!> @}

!! \section arg_table_GFS_GWD_generic_post_finalize Argument Table
!! \htmlinclude GFS_GWD_generic_post_finalize.html
!!
subroutine GFS_GWD_generic_post_finalize()
end subroutine GFS_GWD_generic_post_finalize

Expand Down
4 changes: 2 additions & 2 deletions physics/GFS_GWD_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
dimensions = (horizontal_loop_extent,vertical_dimension)
type = real
kind = kind_phys
intent = inout
intent = in
optional = F
[dvdt]
standard_name = tendency_of_y_wind_due_to_model_physics
Expand All @@ -171,7 +171,7 @@
dimensions = (horizontal_loop_extent,vertical_dimension)
type = real
kind = kind_phys
intent = inout
intent = in
optional = F
[dtdt]
standard_name = tendency_of_air_temperature_due_to_model_physics
Expand Down
74 changes: 37 additions & 37 deletions physics/GFS_MP_generic.F90
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,19 @@ end subroutine GFS_MP_generic_pre_init
!> \section arg_table_GFS_MP_generic_pre_run Argument Table
!! \htmlinclude GFS_MP_generic_pre_run.html
!!
subroutine GFS_MP_generic_pre_run(im, levs, ldiag3d, qdiag3d, do_aw, ntcw, nncl, ntrac, gt0, gq0, save_t, save_q, errmsg, errflg)
subroutine GFS_MP_generic_pre_run(im, levs, ldiag3d, qdiag3d, do_aw, ntcw, nncl, &
ntrac, gt0, gq0, save_t, save_q, errmsg, errflg)
!
use machine, only: kind_phys

implicit none
integer, intent(in) :: im, levs, ntcw, nncl, ntrac
logical, intent(in) :: ldiag3d, qdiag3d, do_aw
real(kind=kind_phys), dimension(im, levs), intent(in) :: gt0
real(kind=kind_phys), dimension(im, levs, ntrac), intent(in) :: gq0
integer, intent(in) :: im, levs, ntcw, nncl, ntrac
logical, intent(in) :: ldiag3d, qdiag3d, do_aw
real(kind=kind_phys), dimension(:,:), intent(in) :: gt0
real(kind=kind_phys), dimension(:,:,:), intent(in) :: gq0

real(kind=kind_phys), dimension(im, levs), intent(inout) :: save_t
real(kind=kind_phys), dimension(im, levs, ntrac), intent(inout) :: save_q
real(kind=kind_phys), dimension(:,:), intent(inout) :: save_t
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: save_q

character(len=*), intent(out) :: errmsg
integer, intent(out) :: errflg
Expand Down Expand Up @@ -102,42 +103,41 @@ subroutine GFS_MP_generic_post_run(im, levs, kdt, nrcm, ncld, nncl, ntcw, ntrac,
logical, intent(in) :: cal_pre, lssav, ldiag3d, qdiag3d, cplflx, cplchm
integer, intent(in) :: index_of_temperature,index_of_process_mp

real(kind=kind_phys), intent(in) :: dtf, frain, con_g
real(kind=kind_phys), dimension(im), intent(in) :: rain1, xlat, xlon, tsfc
real(kind=kind_phys), dimension(im), intent(inout) :: ice, snow, graupel, rainc
real(kind=kind_phys), dimension(im), intent(in) :: rain0, ice0, snow0, graupel0
real(kind=kind_phys), dimension(im,nrcm), intent(in) :: rann
real(kind=kind_phys), dimension(im,levs), intent(in) :: gt0, prsl, save_t, del
real(kind=kind_phys), dimension(im,levs+1), intent(in) :: prsi, phii
real(kind=kind_phys), dimension(im,levs,ntrac), intent(in) :: gq0, save_q

real(kind=kind_phys), dimension(im), intent(in ) :: sr
real(kind=kind_phys), dimension(im), intent(inout) :: rain, domr_diag, domzr_diag, domip_diag, doms_diag, tprcp, &
srflag, cnvprcp, totprcp, totice, totsnw, totgrp, cnvprcpb, &
totprcpb, toticeb, totsnwb, totgrpb, rain_cpl, rainc_cpl, &
snow_cpl, pwat

real(kind=kind_phys), dimension(:,:,:), intent(inout) :: dtend ! only if ldiag3d
real(kind=kind_phys), intent(in) :: dtf, frain, con_g
real(kind=kind_phys), dimension(:), intent(in) :: rain1, xlat, xlon, tsfc
real(kind=kind_phys), dimension(:), intent(inout) :: ice, snow, graupel, rainc
real(kind=kind_phys), dimension(:), intent(in) :: rain0, ice0, snow0, graupel0
real(kind=kind_phys), dimension(:,:), intent(in) :: rann
real(kind=kind_phys), dimension(:,:), intent(in) :: gt0, prsl, save_t, del
real(kind=kind_phys), dimension(:,:), intent(in) :: prsi, phii
real(kind=kind_phys), dimension(:,:,:), intent(in) :: gq0, save_q

real(kind=kind_phys), dimension(:), intent(in ) :: sr
real(kind=kind_phys), dimension(:), intent(inout) :: rain, domr_diag, domzr_diag, domip_diag, doms_diag, tprcp, &
srflag, cnvprcp, totprcp, totice, totsnw, totgrp, cnvprcpb, &
totprcpb, toticeb, totsnwb, totgrpb, pwat
real(kind=kind_phys), dimension(:), intent(inout) :: rain_cpl, rainc_cpl, snow_cpl

real(kind=kind_phys), dimension(:,:,:), intent(inout) :: dtend
integer, dimension(:,:), intent(in) :: dtidx

! Stochastic physics / surface perturbations
real(kind=kind_phys), dimension(im), intent(inout) :: drain_cpl
real(kind=kind_phys), dimension(im), intent(inout) :: dsnow_cpl
real(kind=kind_phys), dimension(:), intent(inout) :: drain_cpl, dsnow_cpl

! Rainfall variables previous time step
integer, intent(in) :: lsm, lsm_ruc, lsm_noahmp
real(kind=kind_phys), dimension(im), intent(inout) :: raincprv
real(kind=kind_phys), dimension(im), intent(inout) :: rainncprv
real(kind=kind_phys), dimension(im), intent(inout) :: iceprv
real(kind=kind_phys), dimension(im), intent(inout) :: snowprv
real(kind=kind_phys), dimension(im), intent(inout) :: graupelprv
real(kind=kind_phys), dimension(im), intent(inout) :: draincprv
real(kind=kind_phys), dimension(im), intent(inout) :: drainncprv
real(kind=kind_phys), dimension(im), intent(inout) :: diceprv
real(kind=kind_phys), dimension(im), intent(inout) :: dsnowprv
real(kind=kind_phys), dimension(im), intent(inout) :: dgraupelprv

real(kind=kind_phys), intent(in) :: dtp
real(kind=kind_phys), dimension(:), intent(inout) :: raincprv
real(kind=kind_phys), dimension(:), intent(inout) :: rainncprv
real(kind=kind_phys), dimension(:), intent(inout) :: iceprv
real(kind=kind_phys), dimension(:), intent(inout) :: snowprv
real(kind=kind_phys), dimension(:), intent(inout) :: graupelprv
real(kind=kind_phys), dimension(:), intent(inout) :: draincprv
real(kind=kind_phys), dimension(:), intent(inout) :: drainncprv
real(kind=kind_phys), dimension(:), intent(inout) :: diceprv
real(kind=kind_phys), dimension(:), intent(inout) :: dsnowprv
real(kind=kind_phys), dimension(:), intent(inout) :: dgraupelprv

real(kind=kind_phys), intent(in) :: dtp

! CCPP error handling
character(len=*), intent(out) :: errmsg
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_MP_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = in
intent = inout
optional = F
[rain1]
standard_name = lwe_thickness_of_explicit_precipitation_amount
Expand Down
Loading