Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwsc_proxy: support creating Support Profile with "status": "existing" #6

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

mackenzie-grimes-noaa
Copy link
Contributor

Linear Issue

IDSSE-1038

Changes

  • Add idss-engine-commons library dependency
    • Only needed for to_iso()
  • Add support for nwsc_proxy webserver POST endpoint so client can control the status of their Support Profile
    • Previously all Support Profiles were created in the "new" category, only to be returned when someone requested /all-events?status=new

Explanation

Now POSTs to /all-events must have a slightly different request body.

Previous

{ 
  // <...full Support Profile JSON> 
}

Now:

{ 
  "status": "existing",  // or "status": "new"
  "data": { 
     // <...full Support Profile JSON> 
  } 
}

@mackenzie-grimes-noaa mackenzie-grimes-noaa marked this pull request as ready for review January 1, 2025 00:33
Copy link
Contributor

@Geary-Layne Geary-Layne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackenzie-grimes-noaa mackenzie-grimes-noaa merged commit 25ac1ff into main Jan 2, 2025
2 checks passed
@mackenzie-grimes-noaa mackenzie-grimes-noaa deleted the proxy-creating-existing branch January 2, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants