Fix request service handling of eval service #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing setup of arguments with values related to communicating with evaluation service, which were incorrectly overwriting dests for analogous args for communicating with data service; also, ensuring the evaluation service SSL dir arg was passed to service manager class.
Protect general execution of RequestService manager class to still be usable even without the evaluation service being online in the Docker stack.
christophertubbs
approved these changes
Sep 19, 2023
| @@ -170,6 +175,10 @@ async def listener(self, websocket: WebSocketServerProtocol, path): | |||
| event_type = MessageEventType.INVALID if req_message is None else req_message.get_message_event_type() | |||
|
|
|||
| if isinstance(req_message, LaunchEvaluationMessage) or isinstance(req_message, OpenEvaluationMessage): | |||
There was a problem hiding this comment.
if isinstance(req_message, (LaunchEvaluationMessage, OpenEvaluationMessage)) instead of if isinstance(req_message, LaunchEvaluationMessage) or isinstance(req_message, OpenEvaluationMessage) might read better here.
| ) | ||
| self._eval_handler_exception = None | ||
| except Exception as e: | ||
| self._evaluation_service_handler = None |
There was a problem hiding this comment.
Might be worth adding some logging here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with some issues in how the request service deals with evaluation service connection details, as the latter doesn't actually exist in the
maindeployment stack yet. These are currently keeping the request service from starting successfully.tryblock, falling back to aNonevalue if something is raisedNone.