Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Imports and Exports #461

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

christophertubbs
Copy link
Contributor

Added the ability to import and export evaluation templates in the evaluation service and added stock templates available to all evaluation service instances.

@christophertubbs christophertubbs added the enhancement New feature or request label Nov 1, 2023
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've reviewed these changes. I wouldn't mind having another set of eyes on it, as this is rather large and I'm not as familiar with the evaluation code as I am with other parts. But if no one has time after a couple more days, I'll come back and approve it.

Remind me @christophertubbs: are those additional tests you'd been developing relatively recently (certainly compared to this) related to this work, or something else? There do seem to be a few pieces being added without modifications/additions to the tests. We can live with it, but it might be good to open an issue for later.

@christophertubbs
Copy link
Contributor Author

Remind me @christophertubbs: are those additional tests you'd been developing relatively recently (certainly compared to this) related to this work, or something else? There do seem to be a few pieces being added without modifications/additions to the tests. We can live with it, but it might be good to open an issue for later.

Unit tests are for bootstrapping for confidence intervals - not this.

@robertbartel
Copy link
Contributor

@christophertubbs, if you'll resolve these conflicts (and assuming tests pass after), I'll go ahead and approve this.

…vent handlers that may be used as generic collections for Pydantic
…ils protocol, added the ability to create the most basic TemplateDetails object by feeding it another TemplateDetails object, began the development of a management command to import and export templates, and updated some of the ModelWrapper generics to play better with type hinting
…emoved the attempted use of 'update_or_create' for SpecificationTemplates, and added support author and modification date tracking for templates.
…ame since that is what templates are referenced by
@robertbartel robertbartel merged commit 576fb10 into NOAA-OWP:master Feb 2, 2024
4 of 8 checks passed
@christophertubbs
Copy link
Contributor Author

lol, I'm still working on it XD

I should have marked it as in draft. I'll open up another PR for it when the new slew of unit tests are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants