-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Imports and Exports #461
Template Imports and Exports #461
Conversation
1b2617b
to
133396a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've reviewed these changes. I wouldn't mind having another set of eyes on it, as this is rather large and I'm not as familiar with the evaluation code as I am with other parts. But if no one has time after a couple more days, I'll come back and approve it.
Remind me @christophertubbs: are those additional tests you'd been developing relatively recently (certainly compared to this) related to this work, or something else? There do seem to be a few pieces being added without modifications/additions to the tests. We can live with it, but it might be good to open an issue for later.
Unit tests are for bootstrapping for confidence intervals - not this. |
@christophertubbs, if you'll resolve these conflicts (and assuming tests pass after), I'll go ahead and approve this. |
…vent handlers that may be used as generic collections for Pydantic
…ils protocol, added the ability to create the most basic TemplateDetails object by feeding it another TemplateDetails object, began the development of a management command to import and export templates, and updated some of the ModelWrapper generics to play better with type hinting
…emoved the attempted use of 'update_or_create' for SpecificationTemplates, and added support author and modification date tracking for templates.
…ame since that is what templates are referenced by
6809c90
to
dff9a84
Compare
lol, I'm still working on it XD I should have marked it as in draft. I'll open up another PR for it when the new slew of unit tests are ready. |
Added the ability to import and export evaluation templates in the evaluation service and added stock templates available to all evaluation service instances.