Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow fixes #629

Merged
merged 12 commits into from
May 21, 2024
Merged

Workflow fixes #629

merged 12 commits into from
May 21, 2024

Commits on May 21, 2024

  1. Fix more CLI issues. 

    - Fix problem with how enum values for CLI param type are handled with
  AllocationParadigm
- Fixing arg parse dest/param names to match up with keyword arg names
  where those are used later (composite_config_data_id and workflow in
  function to handle exec subcommands)
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    eae166b View commit details
    Browse the repository at this point in the history

  2. Fix DmodClient.job_command() to match CLI kwargs.

    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3a97bde View commit details
    Browse the repository at this point in the history

  3. Fix ExistingJobRequestHandler handling. 

    - Fix _generate_request_response receipt of reason and message args to
  account for sources being None values when successful
- Fix use of service_client: it's no longer an async context manager.
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    053684a View commit details
    Browse the repository at this point in the history

  4. Fix SchedulerService msg parser routing, handling. 

    Fixing parsing of message to correct handler function (types should map
to function of an instance), and improving handler functions for job
info and listing requests.
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5ea4e8d View commit details
    Browse the repository at this point in the history

  5. Update AuthClient with optional exception raising. 

    Update apply_auth to optionally raise an exception on failure rather
than return False, via a new keyword arg that defaults to False.
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c4dce92 View commit details
    Browse the repository at this point in the history

  6. Default ExternalRequest session_secret to ''. 

    Make this have a default value of empty string to allow creating an
instance before the secret is available (and then be set later).
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d271bad View commit details
    Browse the repository at this point in the history

  7. Make sure job_id type usage is consistent. 

    Updating SchedulerRequestResponse and SchedulerRequestResponseBody type
hinting for job_id param/attribute, since these are strings in Job.
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9f47635 View commit details
    Browse the repository at this point in the history

  8. Bumping versions and internal dependencies.

    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ae144d8 View commit details
    Browse the repository at this point in the history

  9. Also update partitioner service for scheduler fix. 

    Updating to address NOAA-OWP#628 (scheduler and scheduler service already
addressed).
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c71dfea View commit details
    Browse the repository at this point in the history

  10. Updating tests to be valid with recent changes.

    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    709ac8b View commit details
    Browse the repository at this point in the history

  11. Fix ngen work image builds and lib paths. 

    Adding LD_LIBRARY_PATH as needed and fixing issue with numpy appearing
to not be present (even though it was) by running within Python virtual
directory.
    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4e66913 View commit details
    Browse the repository at this point in the history

  12. Fixing ngen worker entrypoint and image scripts.

    @robertbartel
    robertbartel committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cdb29f8 View commit details
    Browse the repository at this point in the history