More workflow fixes

[robertbartel]

Additional fixes throughout the model exec workflow found in testing.

[aaraney]

Generally, looks great! I left two minor comments that shouldnt take long to address. Thanks, @robertbartel!

[aaraney]

To help provide more context, let's use raise from.

Suggested change

	raise DmodRuntimeError(f"DMOD error when getting dataset state: {str(e)}")
	raise DmodRuntimeError(f"DMOD error when getting dataset state: {str(e)}") from e

[robertbartel]

Don't we get this for free without the explicit usage, since we're inside the handling except block?

[aaraney]

Yes and no. The call stack will propagate like you are suggesting, however the from keyword is giving context that the exception we are raising now is a result of, in this case, e. So, the stack trace will be more appropriately formatted. For example:

def raises():
    raise RuntimeError("some runtime exception")

def normal_catch_and_reraise():
    try:
        raises()
    except Exception as e:
        raise RuntimeError(f"normal catch and reraise: {e}")

normal_catch_and_reraise()

Traceback (most recent call last):
  File "/home/user/e.py", line 6, in normal_catch_and_reraise
    raises()
  File "/home/user/e.py", line 2, in raises
    raise RuntimeError("some runtime exception")
RuntimeError: some runtime exception

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/user/e.py", line 16, in <module>
    normal_catch_and_reraise()
  File "/home/user/e.py", line 8, in normal_catch_and_reraise
    raise RuntimeError(f"normal catch and reraise: {e}")
RuntimeError: normal catch and reraise: some runtime exception

def catch_and_reraise_from():
    try:
        raises()
    except Exception as e:
        raise RuntimeError("catch and reraise from") from e

catch_and_reraise_from()

Traceback (most recent call last):
  File "/home/user/e.py", line 12, in catch_and_reraise_from
    raises()
  File "/home/user/e.py", line 2, in raises
    raise RuntimeError("some runtime exception")
RuntimeError: some runtime exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/user/e.py", line 16, in <module>
    catch_and_reraise_from()
  File "/home/user/e.py", line 14, in catch_and_reraise_from
    raise RuntimeError("catch and reraise from") from e
RuntimeError: catch and reraise from

Notice the presence of The above exception was the direct cause of the following exception: in the second stack trace.

[robertbartel]

Ah, I see. Reviewing the documentation (too quickly) yesterday, I read the part about an implicit mechanism when already being handled, and missed where that actually involves a different exception object attribute. I've made a change, so please re-review when you have a moment.