Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add harvester global mean evaporation #29

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/add harvester global mean evaporation #29

wants to merge 5 commits into from

Conversation

sherrieF
Copy link
Collaborator

This pull request is for the global mean of evaporation. The lhtfl_ave field. Long name is surface upward longwave flux.
This is for number 34 in the replay monitoring google sheets. The following has been done for the calculation of the
evaporation global mean of evaporation.

  • The test data was made from the background forecasts control Netcdf files. The test data files are Netcdf files with
    the lhtfl_ave variable in them.
  • The harvester is global_bucket_evap_ave.py.
  • The hv_registry.py was modified to register the global_bucket_evap_ave harvester procedure.
  • The test code is test_harvester_global_lhtfl.py.
    The test code passed the test of the harvester.

@sherrieF
Added new files for the harvester global_bucket_evaporation_ave.py.
50cf84b 
Added the test for the new harvester global_bucket_evaporation_ave.py
Added test data bfg lhtfl files for testing the new harvester
global_bucket_evaporation_ave.py
@sherrieF
copy files from feature/add-harvester-global_bucket_precip_ave to fea…
d6f74ad 
…ture/add-harvester-global_bucket_evaporation_ave
@sherrieF
added harvester for evaporation mean and the
d9dfa56 
hv_registry.  Added the test data and the test
for the evaporation harvester.
@sherrieF
Changed comments which had precip to evaporation
ddace59
@sherrieF sherrieF requested review from amschne and jrknezha August 17, 2023 19:24
@jrknezha
Copy link
Collaborator

We want to retain the tests and the test data but need to be refactored to use the daily bfg harvester (instead of separate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amschne amschne Awaiting requested review from amschne

@jrknezha jrknezha Awaiting requested review from jrknezha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherrieF @jrknezha