Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CCPP code, separate from FV3 repository #1

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 9, 2019

This PR contains the following changes:

  • merge portability features and bugfixes from CCPP version
    • portability features for GNU and PGI compilers
    • Intel MKL support to replace scrft/dcrft calls (required on macOS) if appropriate MKL flags are passed to build system (on by default only for macOS and generic Linux in NEMSfv3gfs, off for all NOAA and CISL HPC platforms)
    • wrap code in each file in a Fortran module and make use statements as explicit as possible (using only)
    • clean up redundant definitions of number of OpenMP threads and MPI tasks, remove repeated system calls to query those
    • create own la2ga_stochy version of FV3's la2ga code that is optimized for the needs of the stochastic physics package (and as such is faster)
    • add guards that prevent running cellular automata code with non-uniform blocksizes
    • use model namelist variables do_sppt, do_shum, do_skeb, do_sfcperts (similar to do_ca) and compare them to the values in the stochastic physics namelist sections to ensure consistency (this was required for CCPP in the past, and is now also required for IPD, because the IPD data container initialization has to happen entirely before the stochastic physics can be initialized)
  • make necessary changes to use stochastic physics from separate GitHub repository (interface variables to stochastic physics entry routines, makefile)
  • trim trailing whitespaces in all files

…sary changes to use stochastic physics from separate GitHub repository, trim trailing whitespaces
@climbfuji climbfuji marked this pull request as ready for review July 9, 2019 19:46
@pjpegion
Copy link
Collaborator

pjpegion commented Jul 9, 2019

Changes look good.

@pjpegion pjpegion closed this Jul 9, 2019
@pjpegion pjpegion reopened this Jul 9, 2019
@pjpegion pjpegion merged commit 6c4d680 into NOAA-PSL:master Jul 9, 2019
pjpegion added a commit that referenced this pull request Dec 6, 2019
Merge Psd/develop to my fork
climbfuji pushed a commit to climbfuji/stochastic_physics that referenced this pull request Dec 30, 2020
climbfuji pushed a commit to climbfuji/stochastic_physics that referenced this pull request Jan 20, 2021
Add RUC LSM option to land perturbations, add snow albedo and albedo to perturbed parameters
pjpegion pushed a commit that referenced this pull request Sep 26, 2023
jkbk2004 pushed a commit that referenced this pull request Jan 11, 2024
jkbk2004 pushed a commit that referenced this pull request Jan 11, 2024
add lndpint to control lndp interval
mnlevy1981 pushed a commit to ESCOMP/stochastic_physics that referenced this pull request Sep 16, 2024
Updates to let code build with DEBUG=TRUE and gnu compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants