Add optional attribute for variables where necessary #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/optional_arguments
This was referenced May 11, 2024
|
@pjpegion This PR is ready for review! Everything is b4b identical in the UFS-W-M regression tests. |
15 tasks
pjpegion
approved these changes
May 12, 2024
|
Testing for #2205 has completed successfully, please continue with merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All in the title. Required for supporting optional arguments in CCPP (see ufs-community/ufs-weather-model#2205 and PRs listed there).
Working towards NCAR/ccpp-framework#540
This is part of a large set of PRs:
NCAR/ccpp-framework#552
NOAA-EMC/fv3atm#807
https://github.com/ufs-community/ufs-weather-model/pull/2205
ufs-community/ccpp-physics#189
NCAR/ccpp-framework#556 (can be scheduled and merged anytime beforehand)
NOAA-GFDL/GFDL_atmos_cubed_sphere#338
#79
How Has This Been Tested?
ufs-weather-model full regression testing on Hera (all tests b4b)